1099474 - Allow a root actor to not provide a tab list

Status: RESOLVED INACTIVE

(DevTools :: General, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

Attachment: 0002-Bug-XXXXXXXX-allow-root-actors-to-not-supply-a-tabLi.patch

In bug 809561 comment 1:
(In reply to Philipp Kewisch [:Fallen] from bug 809561 comment #1)
> (or better yet, fix devtools to not require a tabList
> implementation).

It sounds like removing the requirement that a root supplies a tab list is desired, and it would greatly simplify my patch in that bug.

I'm attaching a patch that WFM:

* It changes the onListTabs() call to gracefully handle no tab list and still add all the other actors.

* It adds a bit of sugar to the "connect" page, hiding the tablist title when there are no tabs.

* It also includes a change to my patch in bug 809561 - obviously this shouldn't be part of this patch, but I'm including it for this feedback round for reference anyway.

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8523331 [details] [diff] [review]
0002-Bug-XXXXXXXX-allow-root-actors-to-not-supply-a-tabLi.patch

Looks good from a Thunderbird perspective, f=philipp

Comment 2

[Panos Astithas (he/him) [:past] (please ni?)]

Comment on attachment 8523331 [details] [diff] [review]
0002-Bug-XXXXXXXX-allow-root-actors-to-not-supply-a-tabLi.patch

Review of attachment 8523331 [details] [diff] [review]:
-----------------------------------------------------------------

I've been going back and forth on this for a while but I think that I'm sold on it now. We need to make sure all tests still pass of course.