Closed
Bug 1099493
Opened 10 years ago
Closed 10 years ago
fix build failures in non-ion builds
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: stevensn, Assigned: stevensn)
References
Details
Attachments
(1 file, 1 obsolete file)
840 bytes,
patch
|
Details | Diff | Splinter Review |
Two build failures when building on a non-ion platform js/src/jit/BaselineCompiler.cpp:3507:10: error: ?class js::jit::MacroAssembler? has no member named ?callAndPushReturnAddress? js/src/asmjs/AsmJSSignalHandlers.cpp:324:55: error: ‘PC_sig’ was not declared in this scope 9:51.02 return reinterpret_cast<uint8_t**>(&PC_sig(context));
Assignee | ||
Comment 1•10 years ago
|
||
In bug 1046452 I proposed trying to add PC_sig definitions for other platforms. If you don't like the #ifdef JS_CODEGEN_NONE we could try to add those.
Attachment #8523373 -
Flags: review?(luke)
Updated•10 years ago
|
Attachment #8523373 -
Flags: review?(luke) → review+
Assignee | ||
Comment 2•10 years ago
|
||
Bug 1099202 has already fixed the MacroAssembler-none.h part of this patch
Attachment #8523373 -
Attachment is obsolete: true
Assignee | ||
Comment 3•10 years ago
|
||
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=1dfd5dd987d8
Assignee | ||
Comment 4•10 years ago
|
||
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=212302b6f400
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Updated•10 years ago
|
Attachment #8523467 -
Attachment is patch: true
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/67c2b419d836
Assignee: nobody → steve
Keywords: checkin-needed
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/67c2b419d836
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•