Regression: New Tab Page Tiles do not render immediately after clearing history with the Forget Button

UNCONFIRMED
Unassigned

Status

()

Firefox
New Tab Page
UNCONFIRMED
3 years ago
3 years ago

People

(Reporter: Mehmet, Unassigned)

Tracking

33 Branch
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

3 years ago
Created attachment 8523395 [details]
ntp_tiles_render_issue.mov

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_5) AppleWebKit/600.1.17 (KHTML, like Gecko) Version/7.1 Safari/537.85.10

Steps to reproduce:

1.) settings: use about:newtab as your start page
2.) settings: use the start page when firefox starts
3.) clear history via the forget button



Actual results:

New Tab Page tiles do not render immediately. This is since the new ad tiles are present.


Expected results:

New Tab Page tiles should render immediately.
(Reporter)

Updated

3 years ago
Component: Untriaged → New Tab Page

Comment 1

3 years ago
Created attachment 8523414 [details]
ff33.1-newtabpage.jpg

The 2nd line of tites is cut during 1 sec or 2.
Tim, any idea what's causing this? I don't know if this affects Nightly as well... Having seen the preloader fixes, I'm kind of hopeful those would fix this. This also seems like enough of an edgecase that it doesn't warrant uplifting a lot of things to 34 in a panic or something...
Flags: needinfo?(ttaubert)
(In reply to Mehmet Sahin from comment #0)
> New Tab Page tiles do not render immediately. This is since the new ad tiles
> are present.

This statement confuses me: AFAIK we've had these tiles since before we had the forget button - how are you testing with the button but without these tiles?
Flags: needinfo?(mehmet.sahin)
"Render immediately"... this is really about comment 1, right?  The second row of tiles is cut off momentarily.  If so, I don't think this has anything to do with the forget button or about:newtab being the start page or enhanced tiles.

I've seen this myself when opening newtab without its being preloaded.  Something is going on where the grid is not correctly sized for a split second, and the second row of tiles is cut off in the middle.  The movie attachment in this bug is more extreme than I've seen, though: the weird grid lasts much longer.

This needs to be prioritized for more investigation.
(Reporter)

Comment 5

3 years ago
(In reply to :Gijs Kruitbosch from comment #3)
> (In reply to Mehmet Sahin from comment #0)
> > New Tab Page tiles do not render immediately. This is since the new ad tiles
> > are present.
> 
> This statement confuses me: AFAIK we've had these tiles since before we had
> the forget button - how are you testing with the button but without these
> tiles?

In my origin comment I attached a video, how I am testing it. I am seeing it on a MacBookAir 11".

Please let me know how I can help you to reproduce this issue.
Flags: needinfo?(mehmet.sahin)
(In reply to Drew Willcoxon :adw from comment #4)
> I've seen this myself when opening newtab without its being preloaded. 
> Something is going on where the grid is not correctly sized for a split
> second, and the second row of tiles is cut off in the middle.  The movie
> attachment in this bug is more extreme than I've seen, though: the weird
> grid lasts much longer.

We indeed have a few bugs related to the grid having to be sized explicitly with JavaScript. I hope we can in the near future just restyle the whole page - get rid of flexbox because everything is static now, and use media queries to show the right number of tiles. It shouldn't be too hard to do and would probably fix edge cases like this too...
Flags: needinfo?(ttaubert)
You need to log in before you can comment on or make changes to this bug.