Move distributed files into dist/bin/mail instead of dist/bin

RESOLVED WONTFIX

Status

RESOLVED WONTFIX
4 years ago
3 years ago

People

(Reporter: hiro, Assigned: hiro)

Tracking

(Depends on: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments, 2 obsolete attachments)

(Assignee)

Description

4 years ago
Created attachment 8523404 [details] [diff] [review]
WIP patch
Assignee: nobody → hiikezoe
(Assignee)

Updated

4 years ago
Attachment #8523404 - Attachment is obsolete: true
(Assignee)

Updated

4 years ago
Depends on: 1099861
(Assignee)

Comment 2

4 years ago
Filed a separate bug for fixing resouce paths. bug 1099861.
(Assignee)

Comment 3

4 years ago
Created attachment 8524177 [details] [diff] [review]
WIP v3 (build part)
Attachment #8523406 - Attachment is obsolete: true
(Assignee)

Comment 4

4 years ago
Created attachment 8524179 [details] [diff] [review]
WIP v3 (installer part)
(Assignee)

Comment 5

4 years ago
Created attachment 8524181 [details] [diff] [review]
WIP v3 (test part)
(Assignee)

Comment 6

4 years ago
Created attachment 8524182 [details] [diff] [review]
WIP v3 (calendar part)
Just a question, could you add some details why this is needed aside from the failing test? Also, does this work with the new OSX signing changes?

I think a try-run of this would also be good.
(Assignee)

Comment 8

4 years ago
Try run:
https://treeherder.mozilla.org/ui/#/jobs?repo=try-comm-central&revision=12e2d0143d42

There are still lots of failures unfortunately. Most of failures are calendar. The calendar xpcshell tests passed on my local linux. But once make upload or something had done on build server, all of those tests failed. 

What I can tell is that the difference of directory structure between firefox and thunderbird will keep some test failures.

I have no idea about OSX signing changes, but I am worrying about this change would break your work. Of course I am hoping this change does not break calendar or somewhere else.
(Assignee)

Comment 9

4 years ago
Note that the directory structure in dist/bin/xpi-stage when DIST_SUBDIR is set:

OBJDIR/dist/xpi-stage/lightning/DIST_SUBDIR/{chrome, components,...}
Regarding the OSX signing changes, it requires some mozharness changes. I don't know if packaged tests will be affected by this change directly, but if so we'd have to make more changes in bug 1084066.

Regarding the calendar failures, you will likely have to change these lines to load the correct manifest:

http://mxr.mozilla.org/comm-central/source/calendar/test/unit/head_consts.js#15
(Assignee)

Comment 11

4 years ago
Philipp, thanks for the info.
head_consts.js seems to be correct for me. So now I am guessing mozharness changes are necessary unfortunately....
(Assignee)

Updated

4 years ago
Depends on: 1101270
(Assignee)

Updated

4 years ago
No longer blocks: 1099332

Comment 12

4 years ago
Jcranmer, this also looks like it could use your build config experience.
Flags: needinfo?(Pidgeot18)
It's not clear to me that this is useful--it appears to be related to specific test issues that were fixed by other means.
Flags: needinfo?(Pidgeot18)

Comment 14

3 years ago
(In reply to Joshua Cranmer [:jcranmer] from comment #13)
> It's not clear to me that this is useful--it appears to be related to
> specific test issues that were fixed by other means.

closing wontfix based on this comment.
Please reopen if this is incorrect
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.