1099852 - Move distributed files into dist/bin/mail instead of dist/bin

Status: RESOLVED WONTFIX

(Thunderbird :: Build Config, defect)

Description

[Hiroyuki Ikezoe (:hiro)]

Attachment: WIP patch

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: WIP v2

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Filed a separate bug for fixing resouce paths. bug 1099861.

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Attachment: WIP v3 (build part)

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Attachment: WIP v3 (installer part)

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Attachment: WIP v3 (test part)

Comment 6

[Hiroyuki Ikezoe (:hiro)]

Attachment: WIP v3 (calendar part)

Comment 7

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Just a question, could you add some details why this is needed aside from the failing test? Also, does this work with the new OSX signing changes?

I think a try-run of this would also be good.

Comment 8

[Hiroyuki Ikezoe (:hiro)]

Try run:
https://treeherder.mozilla.org/ui/#/jobs?repo=try-comm-central&revision=12e2d0143d42

There are still lots of failures unfortunately. Most of failures are calendar. The calendar xpcshell tests passed on my local linux. But once make upload or something had done on build server, all of those tests failed. 

What I can tell is that the difference of directory structure between firefox and thunderbird will keep some test failures.

I have no idea about OSX signing changes, but I am worrying about this change would break your work. Of course I am hoping this change does not break calendar or somewhere else.

Comment 9

[Hiroyuki Ikezoe (:hiro)]

Note that the directory structure in dist/bin/xpi-stage when DIST_SUBDIR is set:

OBJDIR/dist/xpi-stage/lightning/DIST_SUBDIR/{chrome, components,...}

Comment 10

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Regarding the OSX signing changes, it requires some mozharness changes. I don't know if packaged tests will be affected by this change directly, but if so we'd have to make more changes in bug 1084066.

Regarding the calendar failures, you will likely have to change these lines to load the correct manifest:

http://mxr.mozilla.org/comm-central/source/calendar/test/unit/head_consts.js#15

Comment 11

[Hiroyuki Ikezoe (:hiro)]

Philipp, thanks for the info.
head_consts.js seems to be correct for me. So now I am guessing mozharness changes are necessary unfortunately....

Comment 12

[:aceman]

Jcranmer, this also looks like it could use your build config experience.

Comment 13

[Joshua Cranmer [:jcranmer]]

It's not clear to me that this is useful--it appears to be related to specific test issues that were fixed by other means.

Comment 14

[Wayne Mery (:wsmwk)]

(In reply to Joshua Cranmer [:jcranmer] from comment #13)
> It's not clear to me that this is useful--it appears to be related to
> specific test issues that were fixed by other means.

closing wontfix based on this comment.
Please reopen if this is incorrect