1100127 - Regression rendering ownCloud News (Fx 33 to 34)

Status: RESOLVED FIXED

(Web Compatibility :: Site Reports, defect)

Description

[Michael Monreal [:micmon]]

Attachment: Screenshot from 2014-11-16 18:21:47.png

The attached screenshot shows a regression in how Firefox displays the ownCloud News component between Firefox 33 and 34:

- Top: broken (Firefox 34)
- Bottom: correct (Firefox 33)

Comment 1

[Josh Matthews [:jdm]]

Got a link to the site in question?

Comment 2

[Michael Monreal [:micmon]]

(In reply to Josh Matthews [:jdm] from comment #1)
> Got a link to the site in question?

ownCloud [1] is a self-hosted cloud supporting various "apps" (like plugins). One of those is the news app [2] which shows the regression.

If you do not have access to an ownCloud instance I could create a test account for you on my installation or try to come up with a somewhat reduced test page.

[1] http://owncloud.org/
[2] https://github.com/owncloud/news

Comment 3

[Josh Matthews [:jdm]]

The reduced test page would be ideal, if possible. You could also help us narrow down the regression range window using the mozregression tool - http://mozilla.github.io/mozregression/

Comment 4

[Michael Monreal [:micmon]]

(In reply to Josh Matthews [:jdm] from comment #3)
> The reduced test page would be ideal, if possible. 

I will try.

Comment 5

[Boris Zbarsky [:bzbarsky]]

[Tracking Requested - why for this release]:

Comment 6

[Lawrence Mandel [:lmandel] (use needinfo)]

Tracking 34. Note that we are very late in the 34 cycle. If we're going to take a fix, we're going to need it to be ready by Thu, Nov 20.

Comment 7

[Michael Monreal [:micmon]]

Unfortunately I was not able to produce a meaningful reduced testcase.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Access to an ownCloud instance would be pretty helpful, then....

Comment 9

[Michael Monreal [:micmon]]

(In reply to Please do not ask for reviews for a bit [:bz] from comment #8)
> Access to an ownCloud instance would be pretty helpful, then....

I will send you url/username/pass by email.

Comment 10

[Boris Zbarsky [:bzbarsky]]

Thank you.

Looks like the behavior changed in this m-c push range: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=63f44b4968c2&tochange=82df3654cd80

This is the range in which bug 1015474 landed.

Looking at the page, it is in fact using "display: flex" for "#app-content .utils ul" and if I add this CSS rule to the page:

  #app-content .utils ul * { min-width: 0 }

the layout goes back to what it used to be.

So this looks like the page depending on the old spec draft behavior, unfortunately.  I filed https://github.com/owncloud/news/issues/661

Comment 11

[Liz Henry (:lizzard) (relman/hg->git project)]

This is just a bit too late to take a fix for 34. Though it looks super promising that we have progress!

Comment 12

[Boris Zbarsky [:bzbarsky]]

I don't think there's anything to fix on our end here, if my analysis is correct.  We're just following the (updated) spec.

Comment 13

[Daniel Holbert [:dholbert]]

Yeah, based on comment 10, this turned out to be a Tech Evang bug. (& the actual fixing is now mostly tracked in the github issue for owncloud)

(I thought I already reclassified as tech evang, but I must've not hit "submit" -- sorry about that. Reclassifiying  & canceling tracking-firefox35 request.)

Comment 14

[Michael Monreal [:micmon]]

Thanks to everyone evolved. Hopefully this will be fixed in OC 7.0.4 so that it will work fine in the next stable Firefox.

Comment 15

[Daniel Holbert [:dholbert]]

Fix landed, on the ownCloud issue:
 https://github.com/owncloud/news/commit/dfeb06fea38251b2e34a2ef0e0d586ddd1d7d630

Marking this as FIXED.