1100153 - Gap between browser chrome and app window

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Kevin Grandon :kgrandon]

There is a slight gap occasionally between an appWindow and the rocketbar. I think we might already have a bug filed for this, but not entirely sure.

Comment 1

[GitHub Autolander Bot]

Attachment: [PullReq] KevinGrandon:bug_1100153_browser_chrome_gap to mozilla-b2g:master

Comment 2

[Kevin Grandon :kgrandon]

Comment on attachment 8523554 [details] [review]
[PullReq] KevinGrandon:bug_1100153_browser_chrome_gap to mozilla-b2g:master

Mike - I seem to recall you talking about this bug, but I can't find a bug report about this. Flagging you for review, in case you might be aware of another bug. I think this should fix it, could you take a look?

Comment 3

[Marcia Knous [:marcia]]

Bug 1096301 might be the dupe - mentions a white under the chrome.

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8523554 [details] [review]
[PullReq] KevinGrandon:bug_1100153_browser_chrome_gap to mozilla-b2g:master

Thanks Marcia. Ben - also flagging you for review here since you were potentially investigating bug 1096301. I think that the legacy 4.6rem definitions may be causing this. Also switching to use a CSS var for better readability of the CSS value. Let me know what you think.

Comment 5

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8523554 [details] [review]
[PullReq] KevinGrandon:bug_1100153_browser_chrome_gap to mozilla-b2g:master

This patch looks like the right thing to do, but I don't feel comfortable reviewing this code.

Comment 6

[Kevin Grandon :kgrandon]

Comment on attachment 8523554 [details] [review]
[PullReq] KevinGrandon:bug_1100153_browser_chrome_gap to mozilla-b2g:master

Or Chris - maybe you could review this if you have cycles?

Comment 7

[Chris Lord [:cwiiis]]

Comment on attachment 8523554 [details] [review]
[PullReq] KevinGrandon:bug_1100153_browser_chrome_gap to mozilla-b2g:master

I've not applied the patch, but it looks good and I trust you have :)

Comment 8

[Kevin Grandon :kgrandon]

In master: https://github.com/mozilla-b2g/gaia/commit/42f6d67e4809333a7ce4ed729c620052c940ac96