Closed
Bug 1100164
Opened 10 years ago
Closed 10 years ago
[EME] ClearKey CDM is not accessible in Nightly builds
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: cpearce, Assigned: eflores)
References
(Blocks 1 open bug, )
Details
Attachments
(1 file, 1 obsolete file)
2.03 KB,
patch
|
Unfocused
:
review+
|
Details | Diff | Splinter Review |
For some reason, the ClearKey GMP is usable in locally built Firefox builds, but it's not usable in officially packaged Nightly builds. STR: 1. Update Nightly, disable e10s, set media.eme.enabled=true 2. Load http://people.mozilla.org/~cpearce/eme/sanity.html Observed result, logging: !MediaKeys.isTypeSupported(org.w3.clearkey) Failed to create MediaKeys Expected logging: Created MediaKeys ClearKey GMP is loaded as expected in local m-c builds. If I set MOZ_GMP_PATH to the gmp-clearkey install dir (C:\Program Files (x86)\Nightly\gmp-clearkey\0.1) I get the expected result. Nightly 32bit, 36.0a1 (2014-11-16), Win8.1 x64.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → edwin
Assignee | ||
Comment 1•10 years ago
|
||
Will be fixed in bug 1100450.
Status: NEW → ASSIGNED
Depends on: 1100450
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8525054 -
Flags: review?(bmcbride)
Comment 3•10 years ago
|
||
Comment on attachment 8525054 [details] [diff] [review] bug1100164.patch Review of attachment 8525054 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/mozapps/extensions/internal/OpenH264Provider.jsm @@ +276,5 @@ > if (this.gmpPath && enabled) { > this._log.info("startup() - adding gmp directory " + this.gmpPath); > try { > + let greBinDir = Services.dirsvc.get(NS_GRE_BIN_DIR, Ci.nsILocalFile); > + gmpService.addPluginDirectory(OS.Path.join(greBinDir.path, Copy/paste error? I think this was meant to go about 8 lines further down.
Assignee | ||
Comment 4•10 years ago
|
||
Yeah, cherry pick fail. Apologies for the r?spam.
Attachment #8525054 -
Attachment is obsolete: true
Attachment #8525054 -
Flags: review?(bmcbride)
Attachment #8525059 -
Flags: review?(bmcbride)
Updated•10 years ago
|
Attachment #8525059 -
Flags: review?(bmcbride) → review+
Reporter | ||
Comment 5•10 years ago
|
||
Thanks for reviewing the patch during your conference Blair! https://hg.mozilla.org/integration/mozilla-inbound/rev/5d895a54de81
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5d895a54de81
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Reporter | ||
Comment 7•9 years ago
|
||
Mass update firefox-status to track EME uplift.
You need to log in
before you can comment on or make changes to this bug.
Description
•