Closed Bug 1100168 Opened 5 years ago Closed 5 years ago

Allow pretenuring for all TypeObjects

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: bhackett, Assigned: bhackett)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
When adding the pretenuring stuff we restricted the possible types we could apply this to, only allowing pretenuring for TypeObjects associated with an initialization site or 'new' script.  This works fine for most scripts, but doesn't allow us to pretenure typed objects, which would be nice to do.  (I've been testing perf with a copy of octane-splay rewritten to use typed objects.)  We could carve out another exception for typed objects, but it seems better to just remove this unnecessary complexity as I don't think it was ever really warranted (we already try really hard to give types to objects which distinguish them based on how they are used, for TI to be effective.)
Attachment #8523574 - Flags: review?(terrence)
Comment on attachment 8523574 [details] [diff] [review]
patch

Review of attachment 8523574 [details] [diff] [review]:
-----------------------------------------------------------------

Makes sense.
Attachment #8523574 - Flags: review?(terrence) → review+
https://hg.mozilla.org/mozilla-central/rev/4407bd0c6330
Assignee: nobody → bhackett1024
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.