Closed
Bug 1100173
Opened 10 years ago
Closed 9 years ago
Add baseline ICs for typed object scalar element accesses
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: bhackett1024, Assigned: bhackett1024)
References
Details
Attachments
(1 file)
15.95 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
There are lots of typed object accesses we could potentially optimize with baseline caches, but one basic one seems to be accessing elements of scalar array typed objects. These can be done pretty simply by reusing the baseline caches for typed array element accesses, with the layout of the object mainly affecting how to compute its length and data.
Attachment #8523577 -
Flags: review?(jdemooij)
Updated•10 years ago
|
Attachment #8523577 -
Flags: review?(jdemooij) → review+
Assignee | ||
Comment 1•9 years ago
|
||
I ended up folding this into the patch for bug 1102510, since that patch fixes an issue with these caches (they were still hitting when the typed object had been neutered). https://hg.mozilla.org/integration/mozilla-inbound/rev/c20d396e45b3
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/926e13c29c4b for apparently breaking pretty much everything. https://treeherder.mozilla.org/ui/#/jobs?repo=mozilla-inbound&revision=c20d396e45b3 The previous pushes were all mostly green.
Flags: needinfo?(bhackett1024)
Assignee | ||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/9439c9dbd36e
Flags: needinfo?(bhackett1024)
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9439c9dbd36e
Assignee: nobody → bhackett1024
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Updated•9 years ago
|
Target Milestone: mozilla37 → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•