1100298 - Update private browsing landing page text

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Kevin Grandon :kgrandon]

Just filing this so we don't lose it. Currently the "Learn More" link in FxOS private browsing is currently hard-coded to: https://support.mozilla.org/kb/private-browsing-browse-web-without-saving-info

The specified page is a desktop page, so we may just want to rip this link out for the time being, or we might have to create new content for it.

Comment 1

[Kevin Grandon :kgrandon]

Attachment: Current private browser landing page

Here is a screenshot of the current landing page for private browsing. Wilfred, Francis - I'm not sure if we're going to have a spec for this any more, but do you guys think we need the `Learn more` link, or can we just rip it out? If we do need it, I suppose we should create a new mobile-centric page about private browsing.

Comment 2

[Gregor Wagner [:gwagner]]

Removing nom until we find out what to do with private browsing

Comment 3

[GitHub Autolander Bot]

Attachment: [PullReq] KevinGrandon:bug_1100298_remove_learn_more_link to mozilla-b2g:master

Comment 4

[Kevin Grandon :kgrandon]

I'll probably work on this (and update the text as well).

Comment 5

[Kevin Grandon :kgrandon]

Comment on attachment 8558663 [details] [review]
[PullReq] KevinGrandon:bug_1100298_remove_learn_more_link to mozilla-b2g:master

Mike - could you review this?

Comment 6

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8558663 [details] [review]
[PullReq] KevinGrandon:bug_1100298_remove_learn_more_link to mozilla-b2g:master

Looks good, thanks!

Comment 7

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/3df07538123592a1aa11d149a1846d012e92e63e

Comment 8

[Kevin Grandon :kgrandon]

Comment on attachment 8558663 [details] [review]
[PullReq] KevinGrandon:bug_1100298_remove_learn_more_link to mozilla-b2g:master

Small text/color changes that we would like to uplift to 2.2. Just trying to get these string changes in asap.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Feature implementation.
[User impact] if declined: Not as nice private browsing.
[Testing completed]: Manual testing only as this is mostly stylistic.
[Risk to taking this patch] (and alternatives if risky): Low risk, just style and text changes.
[String changes made]: Yes.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/928082411783b25f35f4f9215da042faa19261df

Comment 10

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on latest nightly build of Flame v2.2&master.

STR:
1.Go to 'New private window' in Browser app.

Actual results: On private browsing screen, it shows new context and no "Learn More" link.
See attachment: verified_Flame_v2.2.png
Reproduce rate: 0/10


Device: Flame v2.2 (Verified) 
Build ID               20150720162506
Gaia Revision          e1e6317f17a840b19af9dbb25f5a771d8d9fa161
Gaia Date              2015-07-15 21:05:11
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/e2d1f1f55803
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150720.195757
Firmware Date          Mon Jul 20 19:58:10 EDT 2015
Bootloader             L1TC000118D0

Device: Flame master (Verified)
Build ID               20150720010206
Gaia Revision          3fac3ed7b8c887351098ffc677769ddc36abb3d0
Gaia Date              2015-07-17 17:53:41
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/202e9233d130
Gecko Version          42.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150720.044158
Firmware Date          Mon Jul 20 04:42:10 EDT 2015
Bootloader             L1TC000118D0

Comment 11

[Shally Li（leave from Mozilla）]

Attachment: verified_Flame_v2.2.png