Closed Bug 1100317 Opened 5 years ago Closed 5 years ago

Gridview doesn't show the last row completely when more tabs open than will fit on a single screen

Categories

(Firefox for Android :: General, defect, P1)

All
Android
defect

Tracking

()

VERIFIED FIXED
Firefox 36

People

(Reporter: mhaigh, Assigned: mhaigh)

References

Details

Attachments

(2 files)

When the user has more tabs open than will fit on a single screen, the gridview cuts off the last row of tabs.  We need to show the last row completely and display some padding at the bottom too.
This is because of this:
http://dxr.mozilla.org/mozilla-central/source/mobile/android/base/tabs/TabsPanel.java#246

The returned value should account for the toolbar height. mcomella hit the same issue with a different symptom in bug 1091587. He might already have a patch.
Priority: -- → P1
Comment on attachment 8525965 [details] [diff] [review]
Gridview doesnt show the last row completely when more tabs open than will fit on a single screen

Review of attachment 8525965 [details] [diff] [review]:
-----------------------------------------------------------------

Yep.
Attachment #8525965 - Flags: review?(lucasr.at.mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/b21965d27318
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Verified as fixed on latest Nightly on Nexus 7(Android 5.0) and Asus Transformer Pad TF300T(Android 4.1.1)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.