1100329 - [Ambient indicator] should follow the animation on edge gestures

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Alberto Pastor [:albertopq]]

STR

1.- Create a notification
2.- Open an app
3.- Perform an edge gesture

Expected:

The ambient indicator moves with the app screenshot

Actual

The ambient indicator remains static

Comment 1

[Alberto Pastor [:albertopq]]

Attachment: Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/26282

Comment 2

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8525180 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/26282

Left some comments on github. Normally I'd just r+ this, but I think we need to fix the tests first, which could require a different approach.

In the meantime, let's get a ui-review from Eric.

Comment 3

[Eric Pang [:epang] UX]

Comment on attachment 8525180 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/26282

Good catch, looks good to me r+.  Thanks for working on this Alberto!

Comment 4

[Alberto Pastor [:albertopq]]

Comment on attachment 8525180 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/26282

Hi Michael, I fixed the performance tests. The problem wasn't about using top or translateY, but that I forgot that the ambient indicator is now relative to the utility tray, so using top on relative positioned elements was causing the reflows. I'm hiding the utility tray (which is absolute) now, so should be fine.

Could you please review again?

Comment 5

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8525180 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/26282

Looks good to me, and works like a charm!

Comment 6

[Alberto Pastor [:albertopq]]

master: https://github.com/mozilla-b2g/gaia/commit/7e43509eeb36baa1786d15fd829ec302786ae18a