Closed Bug 1100329 Opened 7 years ago Closed 7 years ago

[Ambient indicator] should follow the animation on edge gestures

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.2 S1 (5dec)

People

(Reporter: apastor, Assigned: apastor)

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

STR

1.- Create a notification
2.- Open an app
3.- Perform an edge gesture

Expected:

The ambient indicator moves with the app screenshot

Actual

The ambient indicator remains static
Assignee: nobody → apastor
Comment on attachment 8525180 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/26282

Left some comments on github. Normally I'd just r+ this, but I think we need to fix the tests first, which could require a different approach.

In the meantime, let's get a ui-review from Eric.
Attachment #8525180 - Flags: review?(mhenretty) → ui-review?(epang)
Comment on attachment 8525180 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/26282

Good catch, looks good to me r+.  Thanks for working on this Alberto!
Attachment #8525180 - Flags: ui-review?(epang) → ui-review+
Target Milestone: 2.1 S9 (21Nov) → 2.2 S1 (5dec)
Comment on attachment 8525180 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/26282

Hi Michael, I fixed the performance tests. The problem wasn't about using top or translateY, but that I forgot that the ambient indicator is now relative to the utility tray, so using top on relative positioned elements was causing the reflows. I'm hiding the utility tray (which is absolute) now, so should be fine.

Could you please review again?
Attachment #8525180 - Flags: review?(mhenretty)
Comment on attachment 8525180 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/26282

Looks good to me, and works like a charm!
Attachment #8525180 - Flags: review?(mhenretty) → review+
master: https://github.com/mozilla-b2g/gaia/commit/7e43509eeb36baa1786d15fd829ec302786ae18a
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.