1100332 - [Utility tray] [SHB] Pulling up the utility tray is not easy when SHB is enabled

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Alberto Pastor [:albertopq]]

STR:

1.- Enable SHB
2.- Pull down the utility tray
3.- Try to pull it back up

Expected:

Pulling from one of the sides of the SHB restores the utility tray

Actual:

You need to press exactly at the bottom of the utility tray to restore the utility tray. Starting the touch event on the SHB doesn't work.

Comment 1

[Alberto Pastor [:albertopq]]

I remember :gmarty talking about this one, but is not cc'd here, so may be we need to close this as a duplicate?

Comment 2

[Guillaume Marty [:gmarty]]

AFAICT this is a relatively new bug and I don't think there is already an open bug for that.

Comment 3

[Gregor Wagner [:gwagner]]

Is this a regression?

Comment 4

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

I was unable to reproduce this issue on the latest Flame KK 2.2 Engineering and User or Flame KK 2.1 Engineering and User.  Alberto can you please list the build you were on so we can try and see a reproduction?

Environmental Variables:
Device: Flame 2.2 Engineering
BuildID: 20141125035634
Gaia: 824a61cccec4c69be9a86ad5cb629a1f61fa142f
Gecko: acde07cb4e4d
Version: 36.0a1 (2.2) 
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Environmental Variables:
Device: Flame 2.2 User
BuildID: 20141125040209
Gaia: 824a61cccec4c69be9a86ad5cb629a1f61fa142f
Gecko: acde07cb4e4d
Version: 36.0a1 (2.2) 
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Environmental Variables:
Device: Flame 2.1 Engineering
BuildID: 20141125122232
Gaia: da12d7943f0c2ea71ff50ff84336f8544e26b196
Gecko: e3d6062fc2c2
Version: 34.0 (2.1) 
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Environmental Variables:
Device: Flame 2.1 User
BuildID: 20141125001201
Gaia: 1bdd49770e2cb7a7321e6202c9bf036ab5d8f200
Gecko: db893274d9a6
Version: 34.0 (2.1) 
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 5

[Alberto Pastor [:albertopq]]

I tried with today's (20141125160209) and the problem is still there.

Note that you need to pull from almost out of the screen on the bottom. Pulling direrctly the handle, works fine. Try to compare how out of the screen can you start when pulling from the top to the bottom, with how precise you need to be for pulling from the bottom to the top with the SHB. In theory, should be almost the same.

Comment 6

[Chris Kreinbring [:CKreinbring]]

The bug repros on Flame 2.2 and 2.1 engineering with shallow flash.
The repro rate is around 60% using the tip from comment 5.
Actual result: Attempting to swipe up to close the utility tray will not generate a response.

Flame 2.2
BuildID: 20141126035924
Gaia: 41b7be7c67167f367c3c4982ff08651d55455373
Gecko: 7bcc6573d204
Platform Version: 36.0a1
Firmware Version: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Flame 2.1
BuildID: 20141126060024
Gaia: db2e84860f5a7cc334464618c6ea9e92ff82e9dd
Gecko: 4646c3113273
Platform Version: 34.0
Firmware Version: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

--------------------------------------------------------------------------------------------------------

The bug does not repro on Flame 2.0 engineering with shallow flash.
Actual result: When the utility tray is down, it overlaps the software home button so the button does not inhibit attempts to close the utility tray.

BuildID: 20141126053129
Gaia: 348e8be961a5219ebed35c52e1f6f009985108ef
Gecko: 3545791f9d0f
Platform Version: 32.0
Firmware Version: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 7

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

2.0 is not a valid test environment for SHB bugs so this issue is not a regression.

Comment 8

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1100332-shb-utility-tray > mozilla-b2g:master

Comment 9

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8589595 [details] [review]
[gaia] albertopq:1100332-shb-utility-tray > mozilla-b2g:master

Huge improvement!

Comment 10

[GitHub Autolander Bot]

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Comment 11

[Alberto Pastor [:albertopq]]

master: https://github.com/mozilla-b2g/gaia/commit/3ec57570891f3c85483ea494cc40dd76d8b7a115

Comment 12

[Gregor Wagner [:gwagner]]

Can you ask for uplift approval. Its a huge improvement.

Comment 14

[Alberto Pastor [:albertopq]]

Comment on attachment 8589595 [details] [review]
[gaia] albertopq:1100332-shb-utility-tray > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): -
[User impact] if declined: Pulling up the utility tray is not easy when the SHB is enabled
[Testing completed]: Added unit tests
[Risk to taking this patch] (and alternatives if risky): Simple patch with tests
[String changes made]: none

Comment 15

[bhavana bajaj [:bajaj]]

Approving given the low risk, but if we end up having fallouts we will back this out.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/ecf96695dd443030d46d9b2cec5d0fbf7108ad00

Comment 17

[Shally Li（leave from Mozilla）]

This bug has been verified as pass on latest build of Flame v2.2&3.0 and Nexus 5 v2.2&3.0 by the STR in Comment 0.

Actual results: Pulling up the utility tray is easy when SHB is enabled.
See attachment: verified_v2.2&3.0.mp4
Reproduce rate: 0/15


-------------------------------------------------------------------------------
Device: Flame v2.2 build(Pass)
Build ID               20150514162500
Gaia Revision          8d478e4df36ace173b3e505b568f1a5077fed7c3
Gaia Date              2015-05-14 17:30:50
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/666b327287d5
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150514.201419
Firmware Date          Thu May 14 20:14:30 EDT 2015
Bootloader             L1TC000118D0

Device: Flame v3.0 build(Pass)
Build ID               20150514160201
Gaia Revision          8897e1810aa6426ca483269af76ce2bfd2029d25
Gaia Date              2015-05-14 18:49:06
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/59b6d856160c
Gecko Version          41.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150514.192647
Firmware Date          Thu May 14 19:26:58 EDT 2015
Bootloader             L1TC000118D0

Device: Nexus 5 v2.2 build (Pass)
Build ID               20150514162500
Gaia Revision          8d478e4df36ace173b3e505b568f1a5077fed7c3
Gaia Date              2015-05-14 17:30:50
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/666b327287d5
Gecko Version          37.0
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150514.214406
Firmware Date          Thu May 14 21:44:23 EDT 2015
Bootloader             HHZ12f

Device: Nexus 5 v3.0 build (Pass)
Build ID               20150514010203
Gaia Revision          338f66e6a96491d2f5854b188c6b141ceb690d97
Gaia Date              2015-05-13 14:08:45
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/1fab94ad196c
Gecko Version          41.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150514.044222
Firmware Date          Thu May 14 04:42:38 EDT 2015
Bootloader             HHZ12f

Comment 18

[Shally Li（leave from Mozilla）]

Leaving "verifyme" for v2.1 uplift & verification.

Comment 19

[Shally Li（leave from Mozilla）]

Attachment: verified_v2.2&3.0.mp4

Comment 20

[Shally Li（leave from Mozilla）]

Hi bhavana,

The depending on bug 1161549 is "New" status and is not fixed now.

Comment 21

[Shally Li（leave from Mozilla）]

The v2.2&master has verified, so clear 'verifyme' keywords.