Closed Bug 1100346 Opened 5 years ago Closed 5 years ago

about window - updates not downloaded/working if update deactivates add-on/addon like language packs/makes incompatible

Categories

(Firefox :: General, defect, P1, major)

All
Windows 7
defect

Tracking

()

RESOLVED DUPLICATE of bug 1035400

People

(Reporter: realRaven, Assigned: cosmin-malutan)

References

Details

(Keywords: regression)

User Story

If there is an add-on which enforces strict compatibility (<em:strictCompatbility>true</em:strictCompatibility>), checking in Help > About $brandShortName; finds the update, but fails to download it.
Steps to reproduce (tested with Firefox + Thunderbird 35.0a2 20141122 on Windows 8.1 Pro:

1. Install mozilla-aurora version of application but not the latest build. https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/
2. Open from the install directory default/prefs.js and change the update channel to "nightly".
3. Launch the application and install the demo add-on I attached on this bug. If you installed Aurora newer than 35.0a2, you have to modify maxVersion in the install.rdf in the .xpi file to match the Aurora version. The .xpi is a renamed zip.
4. Restart Aurora to complete the add-on install.
5. Open Help > About $brandShortName;

Actual result:
Independent from the preference if updates should be applied automatically (as long as the application warns about add-ons getting incompatible), the update won't get downloaded. It will go straight to Restart $brandShortName as button label.

Expected result:
Warning about incompatible add-ons, being able to install update after confirming the warning.

Attachments

(1 file, 1 obsolete file)

Help / About THunderbird offers an update from 33.0 to [Update to 34.0 Beta 1].

When clicked it outputs the following

1416230705548	addons.update-checker	DEBUG	Requesting https://versioncheck.addons.mozilla.org/update/VersionCheck.php?reqVersion=2&id={e2fda1a4-762b-4020-b5ad-a41df1933103}&version=3.5b1&maxAppVersion=33.*&status=userEnabled&appID={3550f703-e582-4d05-9a08-453d09bdfdc6}&appVersion=34.0&appOS=WINNT&appABI=x86-msvc&locale=en-US&currentAppVersion=33.0&updateType=98&compatMode=normal
 ----------
1416230705552	addons.update-checker	DEBUG	Requesting https://versioncheck.addons.mozilla.org/update/VersionCheck.php?reqVersion=2&id=langpack-de@thunderbird.mozilla.org&version=33.0&maxAppVersion=33.*&status=userEnabled&appID={3550f703-e582-4d05-9a08-453d09bdfdc6}&appVersion=34.0&appOS=WINNT&appABI=x86-msvc&locale=en-US&currentAppVersion=33.0&updateType=98&compatMode=normal
 ----------
1416230705556	addons.update-checker	DEBUG	Requesting https://versioncheck.addons.mozilla.org/update/VersionCheck.php?reqVersion=2&id=langpack-it@thunderbird.mozilla.org&version=33.0&maxAppVersion=33.*&status=userEnabled&appID={3550f703-e582-4d05-9a08-453d09bdfdc6}&appVersion=34.0&appOS=WINNT&appABI=x86-msvc&locale=en-US&currentAppVersion=33.0&updateType=98&compatMode=normal



1416230477363	addons.update-checker	DEBUG	Requesting https://versioncheck.addons.mozilla.org/update/VersionCheck.php?reqVersion=2&id={e2fda1a4-762b-4020-b5ad-a41df1933103}&version=3.5b1&maxAppVersion=33.*&status=userEnabled&appID={3550f703-e582-4d05-9a08-453d09bdfdc6}&appVersion=34.0&appOS=WINNT&appABI=x86-msvc&locale=en-US&currentAppVersion=33.0&updateType=98&compatMode=normal
 ----------
1416230477366	addons.update-checker	DEBUG	Requesting https://versioncheck.addons.mozilla.org/update/VersionCheck.php?reqVersion=2&id=langpack-de@thunderbird.mozilla.org&version=33.0&maxAppVersion=33.*&status=userEnabled&appID={3550f703-e582-4d05-9a08-453d09bdfdc6}&appVersion=34.0&appOS=WINNT&appABI=x86-msvc&locale=en-US&currentAppVersion=33.0&updateType=98&compatMode=normal
 ----------
1416230477369	addons.update-checker	DEBUG	Requesting https://versioncheck.addons.mozilla.org/update/VersionCheck.php?reqVersion=2&id=langpack-it@thunderbird.mozilla.org&version=33.0&maxAppVersion=33.*&status=userEnabled&appID={3550f703-e582-4d05-9a08-453d09bdfdc6}&appVersion=34.0&appOS=WINNT&appABI=x86-msvc&locale=en-US&currentAppVersion=33.0&updateType=98&compatMode=normal
 ----------
1416230478312	addons.update-checker	DEBUG	Found an update entry for {e2fda1a4-762b-4020-b5ad-a41df1933103} version 3.6b1
 ----------
1416230478313	addons.xpi	DEBUG	Found an existing AddonInstall for {e2fda1a4-762b-4020-b5ad-a41df1933103}
 ----------
1416230478361	addons.update-checker	WARN	Update manifest for langpack-de@thunderbird.mozilla.org did not contain an updates property
 ----------
1416230478392	addons.update-checker	WARN	Update manifest for langpack-it@thunderbird.mozilla.org did not contain an updates property


The about Tb dialog then prompts to [Restart] but that doesn't work. When manually restarting, the old version (33.0) is still installed
I have removed my language packs (German and Italian) and then restarted Thunderbird.

After this I was able to install the update using the About Thunderbird dialog.

Differences to previous attempt:

1 - the download took some time (13MB) in the first case it seemed "instant". I assumed it had pre-downloaded the package but it might have failed at that stage already
2 - a OS notification about the update (the one with the megaphone) was displayed (not the case when I tested it earlier)
3 - [Restart to update] worked.
4 - Update installed successfully
Summary: beta update 34,0b1 not working → beta update 34.0b1 not working if Language Packs are installed
This only seems to happen if the language pack gets incompatible if the application gets updated. Updating Earlybird from 20141121 (used the language packs from 20141120 because 21 had none) to upgrade to Earlybird 20141122 worked. But setting the update channel to "nightly" in channel-prefs.js (in defaults/pref in the installation directory) which would cause an upgrade from 35.0a2 to 36.0a1 shows the same behavior. Everything tested on Windows 8.1 Pro 64 bit.

The same issue occurs if an extension with strictCompatibility is installed: https://developer.mozilla.org/en-US/Add-ons/Install_Manifests#strictCompatibility

The update checker finds the update (set app.update.log to true):

AUS:SVC Checker:getUpdateURL - update URL: https://aus3.mozilla.org/update/3/Thunderbird/33.0/20140923230147/WINNT_x86-msvc/en-US/beta/Windows_NT%206.3.0.0%20(x64)/default/default/update.xml?force=1

AUS:SVC Checker:onLoad - number of updates available: 1

The file offered can be downloaded in the browser (and it's independent from the update type partial (mar) or full).
Summary: beta update 34.0b1 not working if Language Packs are installed → updates not downloaded/working if update deactivates add-on/addon like language packs/makes incompatible
Regression window on Windows:
Last good: 20131220
First bad: 20140103

Caused by bug 707489
Blocks: 707489
Keywords: regression
Do you know if firefox suffers from the same problem?
If there is an add-on which enforces strict compatibility (<em:strictCompatbility>true</em:strictCompatibility>), checking in Help > About $brandShortName; finds the update, but fails to download it.
)Steps to reproduce (tested with Firefox + Thunderbird 35.0a2 20141122 on Windows 8.1 Pro:

1. Install mozilla-aurora version of application but not the latest build. https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/
2. Open from the install directory default/prefs.js and change the update channel to "nightly".
3. Launch the application and install the demo add-on I attached on this bug. If you installed Aurora newer than 35.0a2, you have to modify maxVersion in the install.rdf in the .xpi file to match the Aurora version. The .xpi is a renamed zip.
4. Restart Aurora to complete the add-on install.
5. Open Help > About $brandShortName;

Actual result:
Independent from the preference if updates should be applied automatically (as long as the application warns about add-ons getting incompatible), the update won't get downloaded. It will go straight to Restart $brandShortName as button label.

Expected result:
Warning about incompatible add-ons, being able to install update after confirming the warning.
Severity: blocker → major
Component: Installer → Application Update
Product: Thunderbird → Toolkit
Version: 33 → Trunk
Could you try updating by copying the following all on one line into the error console to attempt an update? This will bring up the app update ui vs. the about window ui.

const Cc = Components.classes; const Ci = Components.interfaces; 
Components.classes["@mozilla.org/updates/update-prompt;1"].createInstance(Components.interfaces.nsIUpdatePrompt).checkForUpdates();
> Could you try updating by copying the following all on one line into the
> error console to attempt an update? This will bring up the app update ui vs.
> the about window ui.
The app update ui (billboard) is shown after running the code.
(In reply to Archaeopteryx [:aryx] from comment #8)
> > Could you try updating by copying the following all on one line into the
> > error console to attempt an update? This will bring up the app update ui vs.
> > the about window ui.
> The app update ui (billboard) is shown after running the code.
That is the app update ui that I said would be displayed in comment #7.

Can you try updating using this ui and report back whether this ui suffers from this bug as well? Thanks!
Flags: needinfo?(archaeopteryx)
Sorry for missing it in the first request: Yes, updating with the billboard UI works as expected.
Flags: needinfo?(archaeopteryx)
Thanks! This is most likely a bug in the Firefox and Thunderbird about window code then.
Component: Application Update → General
Product: Toolkit → Firefox
Summary: updates not downloaded/working if update deactivates add-on/addon like language packs/makes incompatible → about window - updates not downloaded/working if update deactivates add-on/addon like language packs/makes incompatible
I suspect that either bug 600500 or bug 950357 introduced this regression.
Blocks: 1106060
Attached patch patch v1.0 (obsolete) — Splinter Review
This was introduced in bug 600500.
Where after checking all addons for updates, if we still have incompatible addons, the newly creatted "Apply.."(applyButtonBillboard) button should be displayed, and not restart button.
https://github.com/mozilla/gecko-dev/commit/4bd0730265906a5be1af1b07cc16f4458bc04f0f#diff-5f0366f67931908a5b65ed6cd46e1297R121

For the case when we still have incompatible addons, the update prompt should be opened, this allows us to disable the incompatible addons and still update. The update prompt opens by clicking on applyButtonBillboard.


To reproduce this bug: 
1 Download an addon that is incompatible with latest Nightly: 
  https://addons.mozilla.org/en-US/firefox/addon/super-tab-mode/?src=ss
2 Download an Nightly build on which the addon works(32.0a1)
3 Install the addon, and try to update:

Expected result:
 When checking for updates it's complete, Firefox should start downloading the update
Actual result:
 When checking for updates it's complete, "Restart ...." button it's displayed, clicking on it does nothing 
 

https://bug1106060.bugzilla.mozilla.org/attachment.cgi?id=8530300
Assignee: nobody → cosmin.malutan
Status: NEW → ASSIGNED
Attachment #8549404 - Flags: review?(steffen.wilberg)
Attachment #8549404 - Flags: review?(shorlander)
Priority: -- → P1
Comment on attachment 8549404 [details] [diff] [review]
patch v1.0

Bug 1035400 has the same fix and has been reviewed so removing review requests.
Attachment #8549404 - Attachment is obsolete: true
Attachment #8549404 - Flags: review?(steffen.wilberg)
Attachment #8549404 - Flags: review?(shorlander)
This bug should be fixed by the patch in bug 1035400 so adding dependency
Depends on: 1035400
Oh, great, this issue was blocking us for implementing the update tests for the about-dialog UI.
Status: ASSIGNED → NEW
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1035400
Duplicate of this bug: 1106060
You need to log in before you can comment on or make changes to this bug.