Closed
Bug 1100378
Opened 10 years ago
Closed 9 years ago
Standalone room view should have an option to retry connecting to a room if something went wrong
Categories
(Hello (Loop) :: Client, defect, P1)
Hello (Loop)
Client
Tracking
(firefox35+ fixed, firefox36 fixed, firefox37 fixed)
backlog | Fx35+ |
People
(Reporter: standard8, Assigned: rgauthier)
References
Details
(Whiteboard: [standalone][rooms])
Attachments
(2 files, 1 obsolete file)
3.63 KB,
patch
|
NiKo
:
review+
|
Details | Diff | Splinter Review |
3.63 KB,
patch
|
NiKo
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
No description provided.
Reporter | ||
Comment 1•10 years ago
|
||
We should introduce an option to the standalone room to try and reconnect to the room if something goes wrong. This is probably a simple retry button, along with an appropriate re-connect.
Summary: Something went wrong in a room → Standalone room view should have an option to retry connecting to a room if something went wrong
Updated•10 years ago
|
backlog: --- → Fx35+
Priority: -- → P2
Whiteboard: [standalone][rooms]
Reporter | ||
Comment 2•10 years ago
|
||
What I think we need to do here is: - In StandaloneRoomInfoArea#_renderContent add a new "button" in the ROOM_STATES.FAILED case - similar to the way it is done in ROOM_STATES.INIT/READY (there's an existing button implementation). - When the button is pressed, automatically re-join the room, i.e. call this.props.joinRoom - which dispatches the roomJoin action. I'm a little worried about edge cases, but I think we should be fine, as when we switch to ROOM_STATES.FAILED, we already do a lot of cleanup. However, it'd be worth some manual testing just to check for anything unexpected.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → rgauthier
Assignee | ||
Comment 3•10 years ago
|
||
Attachment #8530293 -
Flags: ui-review?(nperriault)
Assignee | ||
Comment 4•10 years ago
|
||
Added a test
Attachment #8530293 -
Attachment is obsolete: true
Attachment #8530293 -
Flags: ui-review?(nperriault)
Attachment #8530310 -
Flags: review?(nperriault)
Comment on attachment 8530310 [details] [diff] [review] Retry button for Hello standalone Review of attachment 8530310 [details] [diff] [review]: ----------------------------------------------------------------- The code is good but needs a little style tweak; r=me with proper styling of the Retry button. ::: browser/components/loop/standalone/content/js/standaloneRoomViews.jsx @@ +127,5 @@ > <div className="room-inner-info-area"> > <p className="failed-room-message"> > {this._getFailureString()} > </p> > + <button className="btn btn-join btn-retry" This creates a big pink button; I don't think that's what we want in terms of styling :) https://dl.dropboxusercontent.com/spa/0jzcrapltxzlqds/ef6xhy23.png I think you can reuse the btn-info style as used line 76 of that file.
Attachment #8530310 -
Flags: review?(nperriault) → review+
Assignee | ||
Comment 6•10 years ago
|
||
Addressed comment
Attachment #8530322 -
Flags: review?(nperriault)
Comment 7•10 years ago
|
||
[Tracking Requested - why for this release]: This patch is for the standalone app. We may choose to uplift it for the sake of shared code with desktop. Marking this as tracking Fx35 so we get this fixed before Fx35 goes to Release.
tracking-firefox35:
--- → ?
Comment on attachment 8530322 [details] [diff] [review] Retry button for Hello standalone Review of attachment 8530322 [details] [diff] [review]: ----------------------------------------------------------------- Looks good.
Attachment #8530322 -
Flags: review?(nperriault) → review+
Comment 9•9 years ago
|
||
Hi Niko, t0keshu's out this week. are you comfortable landing this for this week?
Flags: needinfo?(nperriault)
Updated•9 years ago
|
Priority: P2 → P1
(In reply to sescalante from comment #9) > Hi Niko, t0keshu's out this week. are you comfortable landing this for > this week? Sure, I'm just waiting for the tree to reopen ;) https://treestatus.mozilla.org/fx-team
Flags: needinfo?(nperriault)
https://hg.mozilla.org/integration/fx-team/rev/fc97b1d13a0a
Iteration: --- → 37.1
Points: --- → 2
Target Milestone: --- → mozilla37
Comment 12•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/fc97b1d13a0a
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment 13•9 years ago
|
||
Comment on attachment 8530322 [details] [diff] [review] Retry button for Hello standalone Approval Request Comment [Feature/regressing bug #]: N/A [User impact if declined]: Possible merge conflicts if a patch touches standalone and shared code. [Describe test coverage new/current, TBPL]: N/A [Risks and why]: No risk - standalone only - no impact on build [String/UUID change made/needed]: none
Attachment #8530322 -
Flags: approval-mozilla-beta?
Attachment #8530322 -
Flags: approval-mozilla-aurora?
Updated•9 years ago
|
Updated•9 years ago
|
Attachment #8530322 -
Flags: approval-mozilla-beta?
Attachment #8530322 -
Flags: approval-mozilla-beta+
Attachment #8530322 -
Flags: approval-mozilla-aurora?
Attachment #8530322 -
Flags: approval-mozilla-aurora+
Updated•9 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•