1100406 - You have to press the OK button twice to enter a PIN

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Johan Lorenzo [:jlorenzo]]

Pre-requisite: Have a SIM with a PIN

STR
1. Activate airplane mode
2. Deactivate airplane mode => SIM picker is shown. 
3. Enter PIN
4. Press OK

Expected result
You should be taken out of the SIM picker

Actual result
The keyboard goes down and you have to tap SIM picker a second time.

This issues reproes there:
Gaia-Rev        779f05fead3d009f6e7fe713ad0fea16b6f2fb31
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/f2a91c7332be
Build-ID        20141107160205
Version         36.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  39
FW-Date         Thu Oct 16 18:19:14 CST 2014
Bootloader      L1TC00011880

But not on a build 2 days before:
Gaia-Rev        7c9e7cabbde941b976e0e40a3a1d94e21aa9c5e9
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/62990ec7ad78
Build-ID        20141105040206
Version         36.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  39
FW-Date         Thu Oct 16 18:19:14 CST 2014
Bootloader      L1TC00011880

Bug 1045820 may be the cause of the regression.

Comment 1

[Johan Lorenzo [:jlorenzo]]

Doug, do you want a smaller regression window to be sure that bug 1045820 is the cause?

Comment 2

[Johan Lorenzo [:jlorenzo]]

[Blocking Requested - why for this release]: Small regression but which will affect every user with a PIN on his SIM card everyday.

Comment 3

[Doug Sherk (:drs) (inactive)]

I think we might be conflating the SIM picker and SIM PIN unlocker here. I'm also not sure if I got the exact same results as in comment 0. I was unable to get either the SIM picker or the SIM PIN unlocker to show up when disabling airplane mode, either from the Homescreen or the Dialer. However, if I left it open, then toggled airplane mode, I was able to repro the same "actual result" as comment 0.

I think it would be best to do a proper bisection to see what actually broke this. The cause could be bug 1045820, but I don't think that we have enough evidence yet to say so.

Comment 4

[Joshua Mitchell (Inactive)]

Central Regression Window:

Last Working:
Device: Flame 2.2
Build ID: 20141106185508
Gaia: 62c9bd93341fbfa8bf850c21e73465708f93b503
Gecko: 17e190839086
Version: 36.0a1 (2.2)
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

First Broken:
Device: Flame 2.2
Build ID: 20141107035914
Gaia: 779f05fead3d009f6e7fe713ad0fea16b6f2fb31
Gecko: 64f4392d0bdc
Version: 36.0a1 (2.2)
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Gaia/Gecko Swap
Last Working Gaia First Broken Gecko: Issue does NOT reproduce
Gaia: 62c9bd93341fbfa8bf850c21e73465708f93b503
Gecko: 64f4392d0bdc
First Broken Gaia Last Working Gecko: Issue DOES reproduce
Gaia: 779f05fead3d009f6e7fe713ad0fea16b6f2fb31
Gecko: 17e190839086

GAIA pushlog: https://github.com/mozilla-b2g/gaia/compare/62c9bd93341fbfa8bf850c21e73465708f93b503...779f05fead3d009f6e7fe713ad0fea16b6f2fb31

-------------------------------------------------------------------------------

B2G-Inbound Regression Window:

Last Working:
Device: Flame 2.2
Build ID: 20141106221308
Gaia: 284253475469b58d549fa48aee67dd1fc814dbc9
Gecko: 90d6489edae2
Version: 36.0a1 (2.2)
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0


First Broken:
Device: Flame 2.2
Build ID: 20141106225407
Gaia: 83eaaae5fc609aa414d27a13a0237acb2d647a3a
Gecko: 742640491a42
Version: 36.0a1 (2.2)
Firmware Version: v188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Gaia/Gecko Swap
Last Working Gaia First Broken Gecko: Issue does NOT reproduce
Gaia: 284253475469b58d549fa48aee67dd1fc814dbc9
Gecko: 742640491a42
First Broken Gaia Last Working Gecko: Issue DOES reproduce
Gaia: 83eaaae5fc609aa414d27a13a0237acb2d647a3a
Gecko: 90d6489edae2

Gaia pushlog: https://github.com/mozilla-b2g/gaia/compare/284253475469b58d549fa48aee67dd1fc814dbc9...83eaaae5fc609aa414d27a13a0237acb2d647a3a

-----------------------------------------------------------------------------------------------

Broken by Bug 1062819

Comment 5

[Johan Lorenzo [:jlorenzo]]

(In reply to Doug Sherk (:drs) (use needinfo?) from comment #3)
> I think we might be conflating the SIM picker and SIM PIN unlocker here.

You were right, I mixed up SIM picker and SIM unlocker. Sorry.

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

Attachment: patch for master

Advised from rudy so request review to him

Comment 7

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8525121 [details] [review]
patch for master

Looks good to me.
Thanks.

Comment 8

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Just realized that we change from listening to "click" to "touchend" in this bug, Bug 1070883.
That would be an alternative way to solve this issue.

Comment 9

[(inactive after 6/18) Alive Kuo [:alive]]

https://github.com/mozilla-b2g/gaia/commit/229884bec498f94b1891c43cd998f288bf862f0a