Closed Bug 1100482 Opened 5 years ago Closed 5 years ago

Disable fragmented mp4 on Firefox 34

Categories

(Core :: Audio/Video, defect)

34 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla34
Tracking Status
firefox33 --- unaffected
firefox34 + fixed
firefox35 --- unaffected

People

(Reporter: rillian, Assigned: rillian)

References

Details

Attachments

(2 files)

We're concerned about the number of bugs we're still finding in the stagefright demuxer, and the time it's taking to fix them. We think therefore it's best to disable this feature for the Firefox 34 release.

This means mp4 playback won't work on MacOS X until Firefox 35. Windows and Android will fall back to the previous implementations.
Attached patch Disable fmp4Splinter Review
Assignee: nobody → giles
Attachment #8524012 - Flags: review?(cpearce)
Comment on attachment 8524012 [details] [diff] [review]
Disable fmp4

Approval Request Comment
[Feature/regressing bug #]: Bug 1043696

[User impact if declined]: Increased risk of crashes playing video files.

[Describe test coverage new/current, TBPL]: Passing automated tests; issues are mostly with invalid files.

[Risks and why]: Risk is low; we're just flipping the pref bad. This does mean MacOS X won't have native mp4 playback until a later release. Windows and Android will still work using older implementations.

[String/UUID change made/needed]: None.
Attachment #8524012 - Flags: approval-mozilla-beta?
Attachment #8524012 - Flags: review?(cpearce) → review+
Comment on attachment 8524012 [details] [diff] [review]
Disable fmp4

Beta+
Attachment #8524012 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
MP4Reader disabled on all platforms in Firefox 34:
https://hg.mozilla.org/releases/mozilla-beta/rev/19beca5f2b54
Had test failures on Beta:

15:17:47 INFO - 1705 INFO TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_can_play_type_mpeg.html | video/mp4='maybe' - got , expected maybe
15:17:47 INFO - 1706 INFO TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_can_play_type_mpeg.html | audio/mp4='maybe' - got , expected maybe
15:17:47 INFO - 1707 INFO TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_can_play_type_mpeg.html | audio/x-m4a='maybe' - got , expected maybe
15:17:47 INFO - dumping last 2 message(s)
15:17:47 INFO - if you need more context, please use SimpleTest.requestCompleteLog() in your test
15:17:47 INFO - 1708 INFO TEST-PASS | /tests/content/media/test/test_can_play_type_mpeg.html | audio/m4a=''
15:17:47 INFO - 1709 INFO TEST-PASS | /tests/content/media/test/test_can_play_type_mpeg.html | audio/aac=''
15:17:47 INFO - 1710 INFO TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_can_play_type_mpeg.html | video/mp4; codecs="avc1.42E01E, mp4a.40.2"='probably' - got , expected probably
15:17:47 INFO - 1711 INFO TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_can_play_type_mpeg.html | video/mp4; codecs="avc1.42E01E, mp3"='probably' - got , expected probably
15:17:47 INFO - 1712 INFO TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_can_play_type_mpeg.html | video/mp4; codecs="avc1.42001E, mp4a.40.2"='probably' - got , expected probably
15:17:47 INFO - 1713 INFO TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_can_play_type_mpeg.html | video/mp4; codecs="avc1.58A01E, mp4a.40.2"='probably' - got , expected probably
15:17:47 INFO - 1714 INFO TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_can_play_type_mpeg.html | video/mp4; codecs="avc1.4D401E, mp4a.40.2"='probably' - got , expected probably
15:17:47 INFO - 1715 INFO TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_can_play_type_mpeg.html | video/mp4; codecs="avc1.4D401F, mp4a.40.2"='probably' - got , expected probably
15:17:47 INFO - 1716 INFO TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_can_play_type_mpeg.html | video/mp4; codecs="avc1.4D4028, mp4a.40.2"='probably' - got , expected probably
15:17:47 INFO - 1717 INFO TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_can_play_type_mpeg.html | video/mp4; codecs="avc1.64001E, mp4a.40.2"='probably' - got , expected probably
15:17:47 INFO - 1718 INFO TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_can_play_type_mpeg.html | video/mp4; codecs="avc1.64001F, mp4a.40.2"='probably' - got , expected probably
15:17:47 INFO - 1719 INFO TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_can_play_type_mpeg.html | video/mp4; codecs="avc1.42E01E"='probably' - got , expected probably
15:17:47 INFO - 1720 INFO TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_can_play_type_mpeg.html | video/mp4; codecs="avc1.42001E"='probably' - got , expected probably
15:17:47 INFO - 1721 INFO TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_can_play_type_mpeg.html | video/mp4; codecs="avc1.58A01E"='probably' - got , expected probably
15:17:47 INFO - 1722 INFO TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_can_play_type_mpeg.html | video/mp4; codecs="avc1.4D401E"='probably' - got , expected probably
15:17:47 INFO - 1723 INFO TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_can_play_type_mpeg.html | video/mp4; codecs="avc1.64001F"='probably' - got , expected probably
15:17:47 INFO - 1724 INFO TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_can_play_type_mpeg.html | audio/mp4; codecs="mp4a.40.2"='probably' - got , expected probably
15:17:47 INFO - 1725 INFO TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_can_play_type_mpeg.html | audio/mp4; codecs=mp4a.40.2='probably' - got , expected probably
15:17:47 INFO - 1726 INFO TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_can_play_type_mpeg.html | audio/x-m4a; codecs="mp4a.40.2"='probably' - got , expected probably
15:17:47 INFO - 1727 INFO TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_can_play_type_mpeg.html | audio/x-m4a; codecs=mp4a.40.2='probably' - got , expected probably
15:17:47 INFO - 1728 INFO TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_can_play_type_mpeg.html | audio/mp4; codecs="mp4a.40.5"='probably' - got , expected probably
15:17:47 INFO - 1729 INFO TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_can_play_type_mpeg.html | audio/mp4; codecs=mp4a.40.5='probably' - got , expected probably
15:17:47 INFO - 1730 INFO TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_can_play_type_mpeg.html | audio/x-m4a; codecs="mp4a.40.5"='probably' - got , expected probably
15:17:47 INFO - 1731 INFO TEST-UNEXPECTED-FAIL | /tests/content/media/test/test_can_play_type_mpeg.html | audio/x-m4a; codecs=mp4a.40.5='probably' - got , expected probably
15:17:47 INFO - 1732 INFO TEST-OK | /tests/content/media/test/test_can_play_type_mpeg.html | took 643ms 


Pushed a bustage fix:

https://hg.mozilla.org/releases/mozilla-beta/rev/60b2553fe372

We'd forgotten to set a pref, and I had to adjust test_canplay_type_mpeg to reflect that HE-AAC is not advertised as supported except if MP4Reader is disabled.
Additional bustage fix cpearce landed yesterday. r=me. Asking for retroactive approval for part 2 per KWierso on irc.

Approval Request Comment

[Feature/regressing bug #]: Bug 1043696

[User impact if declined]: Increased risk of crashes playing video files on Mac.

[Describe test coverage new/current, TBPL]: Passing automated tests; issues are mostly with invalid files.

[Risks and why]: Risk is low; we're flipping the pref back and adjusting some bitrot in a mochitest. This does mean MacOS X won't have native mp4 playback until a later release. Windows and Android will still work using older implementations.

[String/UUID change made/needed]: None.
Attachment #8524842 - Flags: review+
Attachment #8524842 - Flags: approval-mozilla-beta?
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Comment on attachment 8524842 [details] [diff] [review]
Address test failures on Windows.

I had provided verbal approval for this change. Beta+
Attachment #8524842 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.