Closed Bug 1100497 Opened 5 years ago Closed 4 years ago
_animation .html | timing out after 120000ms . Animated image still doesn't look correct, after poll #2090
This is currently believed to have been triggered by one of these bugs: Bug 1089046, bug 1097405, bug 1097431, bug 1097432, bug 1098108.
We're disabling in the morning if we can't figure it out by then, but Seth is adding some extra assertions to hopefully help diagnose things overnight.
To build on that, I think this is similar to another bug that I've seen happen with some of my try pushes that was triggered by a failure to report all the progress changes and invalidations a decoder produced before shutting it down. (Unfortunately, unlike that one, I could not reproduce this one locally.) Odds are good that the regressing bug is bug 1089046, if that explanation is accurate. My plan is to: 1. Write a patch to fix all known ways that that can happen. 2. Add assertions that should confirm the cause if it happens again. 3. Wait until it happens a couple more times. Otherwise I won't be able to tell if the problem is fixed and whether my theory is correct.
Bug 1100725 has the patches.
OK, I just pushed the patches for bug 1100725. It's possible that those patches fix this issue, but if they don't, please wait until we hit it a couple times before disabling. (If the problem is what I suspect it is, if we *do* hit it again, it'll take the form of an assertion in Decoder.cpp.)
I'm going to wait for some other things to land before trying to fix this again. I'll needinfo myself as a reminder to come back to this, though.
Test disabled in https://hg.mozilla.org/integration/mozilla-inbound/rev/7d2dd850d1f4
Alright, I have a new theory as to the cause here. Bug 1103439 will fix this if my theory is correct. I'm going to try reenabling 'test_animation.html' after that patch lands.
Bug 1262269 re-enabled this test. So far so good.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WORKSFORME
Removing leave-open keyword from resolved bugs, per :sylvestre.
You need to log in before you can comment on or make changes to this bug.