Closed
Bug 1100604
Opened 10 years ago
Closed 10 years ago
Replace LineFind with custom code in RemovePrecompleteEntries macro
Categories
(Firefox :: Installer, defect)
Firefox
Installer
Tracking
()
RESOLVED
FIXED
Firefox 36
People
(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)
References
Details
Attachments
(1 file)
7.54 KB,
patch
|
bbondy
:
review+
lsblakk
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
The LineFind macro makes the code more complex and restricts the use of builtin vars $0 through $R9 so I am replacing it with simpler code.
Assignee | ||
Updated•10 years ago
|
Assignee | ||
Comment 1•10 years ago
|
||
I'll likely replace the other uses of LineFind in a separate bug.
Attachment #8524215 -
Flags: review?(netzen)
Updated•10 years ago
|
Attachment #8524215 -
Flags: review?(netzen) → review+
Assignee | ||
Comment 2•10 years ago
|
||
Pushed to fx-team https://hg.mozilla.org/integration/fx-team/rev/0f95bc7706c0
Target Milestone: --- → Firefox 36
Comment 3•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/0f95bc7706c0
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•10 years ago
|
status-firefox33:
--- → wontfix
status-firefox34:
--- → affected
status-firefox35:
--- → affected
status-firefox36:
--- → fixed
status-firefox37:
--- → unaffected
status-firefox-esr31:
--- → affected
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8524215 [details] [diff] [review] patch rev1 I would like to get this landed for at least Firefox 35 to support bug 1038560. [Approval Request Comment] If this is not a sec:{high,crit} bug, please state case for ESR consideration: Files are not removed on uninstall and files left behind can lead to problems with future installs. User impact if declined: Files are not removed on uninstall and files left behind can lead to problems with future installs. Fix Landed on Version: Firefox 36 Risk to taking this patch (and alternatives if risky): Small. Worst case scenario is that files won't be removed on uninstall. It has been tested thoroughly by myself and has been verified. String or UUID changes made by this patch: None
Assignee | ||
Comment 5•9 years ago
|
||
Comment on attachment 8524215 [details] [diff] [review] patch rev1 I would like to get this landed for at least Firefox 35 to support bug 1038560. [Approval Request Comment] User impact if declined: Files are not removed on uninstall and files left behind can lead to problems with future installs. Fix Landed on Version: Firefox 36 Risk to taking this patch (and alternatives if risky): Small. Worst case scenario is that files won't be removed on uninstall. It has been tested thoroughly by myself and has been verified. String or UUID changes made by this patch: None
Attachment #8524215 -
Flags: approval-mozilla-aurora?
Updated•9 years ago
|
Attachment #8524215 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in
before you can comment on or make changes to this bug.
Description
•