Closed Bug 1100604 Opened 5 years ago Closed 5 years ago

Replace LineFind with custom code in RemovePrecompleteEntries macro

Categories

(Firefox :: Installer, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 36
Tracking Status
firefox33 --- wontfix
firefox34 --- wontfix
firefox35 --- fixed
firefox36 --- fixed
firefox37 --- unaffected
firefox-esr31 --- wontfix

People

(Reporter: rstrong, Assigned: rstrong)

References

Details

Attachments

(1 file)

The LineFind macro makes the code more complex and restricts the use of builtin vars $0 through $R9 so I am replacing it with simpler code.
Attached patch patch rev1Splinter Review
I'll likely replace the other uses of LineFind in a separate bug.
Attachment #8524215 - Flags: review?(netzen)
Attachment #8524215 - Flags: review?(netzen) → review+
https://hg.mozilla.org/mozilla-central/rev/0f95bc7706c0
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Comment on attachment 8524215 [details] [diff] [review]
patch rev1

I would like to get this landed for at least Firefox 35 to support bug 1038560.

[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration: Files are not removed on uninstall and files left behind can lead to problems with future installs.
User impact if declined: Files are not removed on uninstall and files left behind can lead to problems with future installs.
Fix Landed on Version: Firefox 36
Risk to taking this patch (and alternatives if risky): Small. Worst case scenario is that files won't be removed on uninstall. It has been tested thoroughly by myself and has been verified.
String or UUID changes made by this patch: None
Comment on attachment 8524215 [details] [diff] [review]
patch rev1

I would like to get this landed for at least Firefox 35 to support bug 1038560.

[Approval Request Comment]
User impact if declined: Files are not removed on uninstall and files left behind can lead to problems with future installs.
Fix Landed on Version: Firefox 36
Risk to taking this patch (and alternatives if risky): Small. Worst case scenario is that files won't be removed on uninstall. It has been tested thoroughly by myself and has been verified.
String or UUID changes made by this patch: None
Attachment #8524215 - Flags: approval-mozilla-aurora?
Attachment #8524215 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.