The declarations in customCSS.styl need to be reviewed individually and integrated into the site CSS on a case by case basis. In many cases customCSS is altering a CSS declaration elsewhere in our styles, these declarations should be together because: - we should only have to look in one place when altering a style - they often over-ride other declarations we we can reduce total code by combining them - they can benefit from use of variables and mixins. :Florian made a *great* etherpad which will act as a starting point for this work: https://etherpad.mozilla.org/CustomCSS-migration
Commits pushed to master at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/b9b43f0402219afe9c9644a28de2b6d4ab0d7483 Bug 1100643 - Remove.b2g class from styles as it is no longer in use (corresponding macro template has been removed) https://github.com/mozilla/kuma/commit/3ee8743d77d02320c999c4e77c3895fdf9567fa8 Merge pull request #2916 from stephaniehobson/BUG-1100643-customCSS-b2g Bug 1100643: integrate custom CSS - remove .b2g-button
Commits pushed to master at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/85bc7ecea6f6bed146c5838a729a31043d6325dd Bug 1100643: Integrate CustomCSS - fancyTOC Clean up .fancyTOC. This class will probably ultimately be generalized but until then this makes it work better. https://github.com/mozilla/kuma/commit/19992b858695012d6f939041cc013896902ca88f Bug 1100643: Integrate CustomCSS - quicknav Removed .quicknav styles as they are obsolete. The corresponding macro template has been deleted on production. https://github.com/mozilla/kuma/commit/26017360ea586677c5e60accdb43f94020976775 Bug 1100643: Integrate CustomCSS - smallTextMultiColumnBox Another set of classes we can probably generalize but until then... it's not purple and it doesn't break on mobile. https://github.com/mozilla/kuma/commit/95aa20ee92575ba4716e47a61b69541c63bc8f50 Bug 1100643: Integrate CustomCSS - endImageWrapping Replaced this class with the more generic "cleared" where it appeared in production. We can now remove it. https://github.com/mozilla/kuma/commit/34ac5aecf76f284494c37c7496dc1e14655e8651 Bug 1100643: Integrate CustomCSS - sidebar-box Not in use, can't find image associated with it, uses Verdana, pretty sure this one is obsolete. https://github.com/mozilla/kuma/commit/9af2884a933561169d1b8361ecbe4cfecbd93142 Bug 1100643: Integrate CustomCSS - tab-content-box Not in use. https://github.com/mozilla/kuma/commit/6cb4c0f0fbee2f4e2322d20003685ea359c10355 Bug 1100643: Integrate CustomCSS - action-driven Not in use. https://github.com/mozilla/kuma/commit/f1ccf0e5f6edcd7f4989ae84340182a860b0ca77 Bug 1100643: Integrate CustomCSS - standardSidebar Switched to variables and mixing where appropriate. Modernized the look a bit and made it full width on small mobile screens to try to avoid breakages. https://github.com/mozilla/kuma/commit/62655b62124e788dd33c3a87a6209e2c045ed946 Bug 1100643: Integrate CustomCSS - RTL fixes Integrated fixes into main CSS, in some cases the fix was already in place. https://github.com/mozilla/kuma/commit/d0df35ba7a921bd1108376ff3f1d0e78207385a3 Bug 1100643: Integrate CustomCSS - .spec-* Everything should be .redesign now. https://github.com/mozilla/kuma/commit/3d6d46944ae70f7cfc15732e799ea1f24b533d4d Bug 1100643: Integrate CustomCSS - htab It's all .redesign now. https://github.com/mozilla/kuma/commit/e2fc1ee4b952e7415ee0112b15568d51cd1073ea Bug 1100643: Integrate CustomCSS - revert removal of action-driven This reverts commit cfb15feabccbc12f3fa30f0a25a2332d023e175d. https://github.com/mozilla/kuma/commit/c483df8268f6bdfc5b471b0ff17daef1659f2692 Bug 1100643: Integrate CustomCSS - remove invalid property from fancyTOC declaration https://github.com/mozilla/kuma/commit/79217a3062f7d186842b77b631819aeebfe6272f Merge pull request #2967 from stephaniehobson/bug-1100643-empty-customcss Bug 1100643 empty customcss
Commits pushed to master at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/9d91232aaa7dac59c79ead48293553ecf340b1e8 Bug 1100643: Review card-grid Moved card-grid declaration out of customcss file, simplified (moved it to flex box), and variablized it. https://github.com/mozilla/kuma/commit/cc30066ec62ac8154e1968cb3cfce735a7304c7b Merge pull request #3683 from stephaniehobson/1100643-card-grid Bug 1100643: Review card-grid
You need to log in before you can comment on or make changes to this bug.