110065 - Context menu of news:// URLs doesn't contain Open Link in New Window/Tab

Status: RESOLVED EXPIRED

(SeaMonkey :: UI Design, defect)

Description

[Jerome Lacoste]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9.5) Gecko/20011011
BuildID:    2001101117

When right clicking on a news link (news://), the 'Open in a new tab' option is
not available. But clicking on the link does open the page in the browser.

Reproducible: Always
Steps to Reproduce:
1. Go on http://www.mozilla.org/hacking/portable-cpp.html#cpp_casts
2. Right click on the link named 'explanation' pointing to
news://news.mozilla.org:119/36718AB4.4134F58C%40netscape.com

Actual Results:  Menu appears do not contain 'Open in new Tab' option

Expected Results:  Menu appears offers 'Open in new Tab' option

Closest bug found:
101955 'Middle-click -> Open in new tab fails for Mail/News URLs'
I've put the bug on All platform, All OS and minor (one can use CTRL-T and copy
the link even if it is not that nice).

Comment 1

[Olav Vitters]

*** This bug has been marked as a duplicate of 101955 ***

Comment 2

[Jerome Lacoste]

I am the reporter, and I would like to point out that in my comments, I
mentionned bug 101955, but didn't think it was a duplicate.
Bug 101955 wants that middle click acts as Open in New Tab from the Mail/News.
This one requires 'Open In New tab' accessible from right click menu, within the
Navigator. This seems to be different.
Can someone confirm these bugs are really duplicates?

Comment 3

[Niklas Mehner]

Yes, this is no duplicate. Bug 101955 is about clicking a link in a mail, this
is about clicking a link in the browser.

But it is important (imo) that both menu entries: "Open in new Window" and "Open
in new Tab" are missing (So this is probably not a tab-browser issue).
Middle-click to open in a new tab works.

Comment 4

[Olav Vitters]

Oops.. I've marked this bug as a dupe because of bug 107557.

But I seem to have been sleeping and have misread your bugreport
(understatement:).. sorry!

Reopening.

Comment 5

[Jerome Lacoste]

Bug has not been confirmed. I would like it to go open :)

The problem comes from:
[
http://lxr.mozilla.org/seamonkey/source/xpfe/communicator/resources/content/nsContextMenu.js#82
]

where the option 'Open in New Tab' appears only if the link is saveable, but
news links are not saveable (bug 114843).

If bug 114843 isn't to be solved anytime soon, I can provide a hack that would
make us. But I don't think it is the right way to go.

If bug 114843 isn't a real bug, then solving it will probably solve that one
automatically.

Comment 6

[Boris Zbarsky [:bzbarsky]]

why do we require a link to be saveable to "open" it??

Comment 7

[Alvaro Munoz-Aycuens]

http://bugzilla.mozilla.org/show_bug.cgi?id=110065

Comment 8

[sairuh (rarely reading bugmail)]

*** Bug 116085 has been marked as a duplicate of this bug. ***

Comment 9

[Alvaro Munoz-Aycuens]

damn, wrong tab, sorry for the stupid comment :(

Comment 10

[David Hyatt]

Reassigning to new component owner.

Comment 11

[justin hugh daly]

should there be a separate bug opened for the additional 'open in new window'
menu item that is missing, or is one already out there?

Comment 12

[jag (Peter Annema)]

-> future

Comment 13

[Jonas Jørgensen]

This bug cannot be a Tabbed Browser issue since both open in new window and open
in new tab is missing. --> XP apps: GUI features.

Comment 14

[Stefan Borggraefe]

I have a patch for this.

Comment 15

[Stefan Borggraefe]

Attachment: Show Open in new Window/Tab menu items for news/snews links

initOpenItems doesn´t use isLinkSaveable anymore. The open menu items are shown
for all protocols except mailto, javascript and irc.

This patch also fixes a small issue with the isLinkSaveable function: irc-links
were saveable, so the "Save Link Target As..." Menu item was falsely shown.

Comment 16

[Stefan Borggraefe]

Comment on attachment 122503 [details] [diff] [review]
Show Open in new Window/Tab menu items for news/snews links

timeless made some suggestions on IRC I´ll try to incorporate before requesting
r/sr.

Comment 17

[Stefan Borggraefe]

Attachment: Test document

Test document with links to test whether the correct context menu items appear.


I think rather than blacklisting some protocols a better approach would be to
whitlist the protocols which can be saved and opened in new windows/tabs. After
some testing I think these are:

http, https, ftp, news, snews, data and gopher.

One problem remains: If MailNews is not installed news and snews are nor
registered protocols and the context menu items don't work in this case. This
method

http://lxr.mozilla.org/mozilla/source/netwerk/base/public/nsIExternalProtocolHandler.idl#49


seems to be exactly what would be needed to solve this problem, but I think it
can't be used from JavaScript. Or?

Comment 18

[Stefan Borggraefe]

(In reply to comment #17)
> One problem remains: If MailNews is not installed news and snews are nor
> registered protocols and the context menu items don't work in this case.

On a second thought this is a marginal problem given that even a left-click on
the link doesn't work in this case. You get an alert "<protocol name> is not a
registered protocol".

(In reply to comment #7)
> why do we require a link to be saveable to "open" it??

It's not a requirement. It just happens to be the case that both classes of
links are nearly identical at the moment, so the onSaveableLink property is
reused. If there are more cases of links that aren't saveable but can be opened
in a new window/tab in the future these could be added to this if-condition:

http://lxr.mozilla.org/seamonkey/source/xpfe/communicator/resources/content/nsContextMenu.js#108

Comment 19

[Stefan Borggraefe]

Attachment: Better patch

This patch makes the menu items "Open Link in New Tab", "Open Link in New
Window" and "Save Link Target As..." available to all protocols where these
actions work.

Comment 20

[timeless]

there's work on an api for this. perhaps you should poke and rely on that instead.

Comment 21

[Boris Zbarsky [:bzbarsky]]

I agree with comment 20.  See work in bug 229168

Comment 22

[Robert Kaiser]

MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but has been without a comment since the inception of the SeaMonkey project. This means that it was logged against the old Mozilla suite and we cannot determine that it's still valid for the current SeaMonkey suite. Because of this, we are setting it to an UNCONFIRMED state.

If you can confirm that this report still applies to current SeaMonkey 2.x nightly builds, please set it back to the NEW state along with a comment on how you reproduced it on what Build ID, or if it's an enhancement request, why it's still worth implementing and in what way.
If you can confirm that the report doesn't apply to current SeaMonkey 2.x nightly builds, please set it to the appropriate RESOLVED state (WORKSFORME, INVALID, WONTFIX, or similar).
If no action happens within the next few months, we move this bug report to an EXPIRED state.

Query tag for this change: mass-UNCONFIRM-20090614

Comment 23

[Robert Kaiser]

MASS-CHANGE:
This bug report is registered in the SeaMonkey product, but still has no comment since the inception of the SeaMonkey project 5 years ago.

Because of this, we're resolving the bug as EXPIRED.

If you still can reproduce the bug on SeaMonkey 2 or otherwise think it's still valid, please REOPEN it and if it is a platform or toolkit issue, move it to the according component.

Query tag for this change: EXPIRED-20100420