Closed Bug 1100662 Opened 5 years ago Closed 4 years ago
_notification _tab _switching .js to work in e10s mode
This test has some custom waitForFocus type function, unclear if it is needed or if it can just be changed to use waitForFocus.
Assignee: nobody → jaws
Status: NEW → ASSIGNED
I removed the portion of the test that opened a new window and the associating interaction with file_dom_notifications.html that changed focus to the new window. The test still checks that event.defaultPrevented is true as well as that the tabs are not switched, which should be sufficient.
The head.js changes weren't needed.
Attachment #8685134 - Flags: review?(MattN+bmo) → review?(gijskruitbosch+bugs)
Comment on attachment 8685134 [details] [diff] [review] Patch v1.1 Review of attachment 8685134 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #8685134 - Flags: review?(gijskruitbosch+bugs) → review+
Backed out for breaking the test: https://treeherder.mozilla.org/logviewer.html#?job_id=5676917&repo=fx-team https://hg.mozilla.org/integration/fx-team/rev/628b7b9e2c69
Although the try run looks pretty noisy, there are no failures for leaving the window around anymore with this tweaked patch.
https://hg.mozilla.org/integration/fx-team/rev/0403cb97fb51eb7a05ae2f8091fe031d79ae6ae1 Bug 1100662 - Fix browser_notification_tab_switching.js to work in e10s mode. r=MattN
Comment on attachment 8691423 [details] [diff] [review] Patch v2 Approval Request Comment [Feature/regressing bug #]: more test coverage for new feature work around push notifications releasing in 44 [User impact if declined]: less test coverage [Describe test coverage new/current, TreeHerder]: this is updating an automated test [Risks and why]: none [String/UUID change made/needed]: none
Attachment #8691423 - Flags: approval-mozilla-aurora?
Comment on attachment 8691423 [details] [diff] [review] Patch v2 test only change. Aurora44+
Attachment #8691423 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.