Closed Bug 1100662 Opened 5 years ago Closed 4 years ago

Fix browser_notification_tab_switching.js to work in e10s mode

Categories

(Firefox :: Tabbed Browser, defect)

defect
Not set
Points:
5

Tracking

()

RESOLVED FIXED
Firefox 45
Tracking Status
e10s + ---
firefox44 --- fixed
firefox45 --- fixed
b2g-v2.5 --- fixed

People

(Reporter: Gijs, Assigned: jaws)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 2 obsolete files)

This test requires focus to work and does a bunch of direct access to the content window which fails:

765 INFO Console message: [JavaScript Error: "[object CPOW [Exception... "Failure"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: resource://gre/modules/RemoteAddonsChild.jsm :: EventTargetChild.prototype.handleEvent :: line 389"  data: no]]" {file: "resource://gre/modules/RemoteAddonsParent.jsm" line: 488}]

and causes the test to time out.
Flags: qe-verify-
Flags: in-testsuite+
Flags: firefox-backlog+
e10s test bugs should block tracking-e10s=+
This test has some custom waitForFocus type function, unclear if it is needed or if it can just be changed to use waitForFocus.
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Attached patch Patch (obsolete) — Splinter Review
I removed the portion of the test that opened a new window and the associating interaction with file_dom_notifications.html that changed focus to the new window. The test still checks that event.defaultPrevented is true as well as that the tabs are not switched, which should be sufficient.
Attachment #8685130 - Flags: review?(MattN+bmo)
Attached patch Patch v1.1 (obsolete) — Splinter Review
The head.js changes weren't needed.
Attachment #8685130 - Attachment is obsolete: true
Attachment #8685130 - Flags: review?(MattN+bmo)
Attachment #8685134 - Flags: review?(MattN+bmo)
Attachment #8685134 - Flags: review?(MattN+bmo) → review?(gijskruitbosch+bugs)
Comment on attachment 8685134 [details] [diff] [review]
Patch v1.1

Review of attachment 8685134 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8685134 - Flags: review?(gijskruitbosch+bugs) → review+
Attached patch Patch v2Splinter Review
Although the try run looks pretty noisy, there are no failures for leaving the window around anymore with this tweaked patch.
Attachment #8685134 - Attachment is obsolete: true
Flags: needinfo?(jaws)
Attachment #8691423 - Flags: review+
https://hg.mozilla.org/integration/fx-team/rev/0403cb97fb51eb7a05ae2f8091fe031d79ae6ae1
Bug 1100662 - Fix browser_notification_tab_switching.js to work in e10s mode. r=MattN
https://hg.mozilla.org/mozilla-central/rev/0403cb97fb51
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
Comment on attachment 8691423 [details] [diff] [review]
Patch v2

Approval Request Comment
[Feature/regressing bug #]: more test coverage for new feature work around push notifications releasing in 44
[User impact if declined]: less test coverage
[Describe test coverage new/current, TreeHerder]: this is updating an automated test
[Risks and why]: none
[String/UUID change made/needed]: none
Attachment #8691423 - Flags: approval-mozilla-aurora?
Comment on attachment 8691423 [details] [diff] [review]
Patch v2

test only change. Aurora44+
Attachment #8691423 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.