1100699 - Deprecate concept of 'inverted' in favor of explicit origin location

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Kelsey Gilbert [:jgilbert]]

Attachment: 0001-Use-gl-OriginPos-instead-of-isInverted.patch

We have a bunch of `isInverted` spaghetti, but it sometimes tricky to figure out what it all means. Y-flip is traditionally tricky because two wrongs can make a right. However, if you skip either of the wrongs, it's now wrong again.

Explicitly calling out what the origin for an image is should reduce the likelihood of having these issues.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8524205 [details] [diff] [review]
0001-Use-gl-OriginPos-instead-of-isInverted.patch

Review of attachment 8524205 [details] [diff] [review]:
-----------------------------------------------------------------

This doesn't build for me, but I agree with it in principal. I'll try to fix it up and make sure everything still works with video and Flash.

Comment 2

[Kelsey Gilbert [:jgilbert]]

Attachment: 0001-Use-gl-OriginPos-instead-of-isInverted.patch

Comment 3

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8529440 [details] [diff] [review]
0001-Use-gl-OriginPos-instead-of-isInverted.patch

Review of attachment 8529440 [details] [diff] [review]:
-----------------------------------------------------------------

Bit of an rs, since I didn't check every change individually, but the concept looks great!

Comment 4

[Kelsey Gilbert [:jgilbert]]

I can't test flash on the device I have, but videos seem fine. Everything on [1] is right-side up. 

[1]: http://www.quirksmode.org/html5/tests/video.html

Comment 5

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8529440 [details] [diff] [review]
0001-Use-gl-OriginPos-instead-of-isInverted.patch

Review of attachment 8529440 [details] [diff] [review]:
-----------------------------------------------------------------

I'm a fan.

Comment 6

[Kelsey Gilbert [:jgilbert]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8116cca43683

Comment 7

[Kelsey Gilbert [:jgilbert]]

Attachment: 0001-Use-gl-OriginPos-instead-of-isInverted.patch

r=mattwoodrow,snorp

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e1dd807b8b2a

Comment 9

[James Willcox (:snorp) ([e-mail]) (he/him)]

This seems to have caused some MP4 videos to appear upside-down on Android.

Comment 10

[Jeff Muizelaar [:jrmuizel]]

I wonder if this caused the webgl map flip problem we got in 37