Closed Bug 1100721 Opened 10 years ago Closed 10 years ago

During stub install use the precomplete file to determine files to uninstall instead of the uninstall.log

Categories

(Firefox :: Installer, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 36
Tracking Status
firefox33 --- wontfix
firefox34 --- wontfix
firefox35 --- fixed
firefox36 --- fixed
firefox-esr31 --- unaffected

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

References

Details

Attachments

(1 file)

This is a much better source for the files and directories and I recently noticed that new files aren't always being added to the uninstall.log possibly due to the numerous changes to app update especially with the addition of staging.
Attached patch patch rev1Splinter Review
Attachment #8524248 - Flags: review?(netzen)
Attachment #8524248 - Flags: review?(netzen) → review+
Pushed to fx-team
https://hg.mozilla.org/integration/fx-team/rev/a11df8aad9be
Target Milestone: --- → Firefox 36
https://hg.mozilla.org/mozilla-central/rev/a11df8aad9be
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment on attachment 8524248 [details] [diff] [review]
patch rev1

I would like to get this landed for at least Firefox 35. This is not needed on ESR since ESR doesn't have a stub installer.

[Approval Request Comment]
User impact if declined: Files are not removed on install and files left behind can lead to problems with the install.
Fix Landed on Version: Firefox 36
Risk to taking this patch (and alternatives if risky): Small. Worst case scenario is that files won't be removed on install. It has been tested thoroughly by myself and has been verified.
String or UUID changes made by this patch: None
Attachment #8524248 - Flags: approval-mozilla-beta?
Attachment #8524248 - Flags: approval-mozilla-aurora?
Comment on attachment 8524248 [details] [diff] [review]
patch rev1

It's too late for Firefox 34. We can consider this change for Firefox 35.
Attachment #8524248 - Flags: approval-mozilla-beta? → approval-mozilla-beta-
Attachment #8524248 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.