Closed Bug 1100750 Opened 7 years ago Closed 7 years ago

Handle developer usernames that contain unacceptable characters like '-'

Categories

(Firefox Build System :: Android Studio and Gradle Integration, defect)

All
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla36

People

(Reporter: rnewman, Assigned: rnewman)

Details

Attachments

(1 file)

E.g.,

13:47.89 /home/chun-min/Work/firefox/obj-arm-linux-androideabi/mobile/android/tests/background/junit3/AndroidManifest.xml:11: Tag <uses-permission> attribute name has invalid character '-'.

from


<?xml version="1.0" encoding="utf-8"?>
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
    package="org.mozilla.gecko.browser.tests"
    sharedUserId="org.mozilla.fennec_chun-min.sharedID"
Commands work in shell, so I'm assuming they'll work in the script itself.
Attachment #8524306 - Flags: review?(nalexander)
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
Comment on attachment 8524306 [details] [diff] [review]
Untested patch. v1

Review of attachment 8524306 [details] [diff] [review]:
-----------------------------------------------------------------

I see lots of sed in configure.in, so we should be okay here.  If not, we'll back out :/

Might as well do it in b2g/branding/unofficial/configure.sh as well.
Attachment #8524306 - Flags: review?(nalexander) → review+
https://hg.mozilla.org/mozilla-central/rev/e7a7c9c5dfe7
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 36 → mozilla36
You need to log in before you can comment on or make changes to this bug.