Closed Bug 1100764 Opened 7 years ago Closed 7 years ago

Contacts move up and down when hovering over them

Categories

(Hello (Loop) :: Client, defect, P2)

All
Windows 8
defect
Points:
3

Tracking

(firefox35 fixed, firefox36 fixed)

RESOLVED FIXED
mozilla36
Iteration:
36.3
Tracking Status
firefox35 --- fixed
firefox36 --- fixed
Blocking Flags:
backlog Fx35+

People

(Reporter: jaws, Assigned: jaws)

Details

(Whiteboard: [good first verify])

Attachments

(2 files)

Attached file Screencast of bug
See attached screencast.

STR:
Add two contacts
Move mouse between the two back and forth

ER:
The individual contacts do not move.

AR:
The contacts jump around like they have ants in their paints
This is fine on Mac, so I suspect this is windows-only.
OS: All → Windows 8
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Iteration: --- → 36.3
Points: --- → 3
Flags: qe-verify-
Flags: firefox-backlog+
Attached patch PatchSplinter Review
A contact has a height of 51px, with 5px padding-top and 5px padding-bottom. This leaves the contact with 41px for the content box. When a contact is hovered, we show icons next to the contact's details. Previously, this box had a height of 43px, which included 12px padding-top and 12px padding-bottom. Since the 43px height of the icons box was larger than the 41px for contact's content-box, the contact grew in size by 2px when hovered.

This patch changes the icon to have 10px of padding on all sides (it previously used 10px left and right), and thus the height of the icon box will now be 39px, smaller than the 41px content-box of the contact and doesn't cause contacts to grow in height when hovered.

I also changed some `background` properties in the CSS to use `background-color` since they didn't need to be using the shorthand.
Attachment #8525645 - Flags: review?(mdeboer)
backlog: --- → Fx35+
Priority: -- → P2
Comment on attachment 8525645 [details] [diff] [review]
Patch

Review of attachment 8525645 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Ship it!
Attachment #8525645 - Flags: review?(mdeboer) → review+
https://hg.mozilla.org/mozilla-central/rev/befb49bad81b
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla36
Comment on attachment 8525645 [details] [diff] [review]
Patch

Approval Request Comment
[Risks and why]: Loop rooms code needed for 35 pref-on
CSS-only change that cleans up a UI issue.
[String/UUID change made/needed]: none
Attachment #8525645 - Flags: approval-mozilla-aurora?
Attachment #8525645 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Flags: in-moztrap-
Whiteboard: [good first verify]
You need to log in before you can comment on or make changes to this bug.