1100799 - Edit recurrence dialog: recurrence rule preview doesn't work

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[Decathlon]

Steps to reproduce:
create a new event and select Repeat custom;

Result:
in the edit recurrence dialog the minimonths that show the preview of the recurrence rule don't have any day marked in bold. Changing the rule doesn't change the preview.

Comment 1

[Decathlon]

Attachment: patch - v1

The patch for bug 1063085 causes this bug but it's not completely clear to me why.
The changes in calendar-event-dialog-recurrence-preview.xml should be correct given the previous code:
http:// mzl.la/1wRK1Bk

The method getBoxForDate() in the minimonth interprets the date as a calIDateTime when instead is a Date.
I think that a fix like this patch should be correct.

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8524453 [details] [diff] [review]
patch - v1

Review of attachment 8524453 [details] [diff] [review]:
-----------------------------------------------------------------

Since this is the only caller for getBoxForDate, I'd prefer changing that method to only accept a calIDateTime instead. I don't think allowing both types is a good idea and only causes confusion.

Comment 3

[Decathlon]

Attachment: patch - v2

(In reply to Philipp Kewisch [:Fallen] from comment #2)

> Since this is the only caller for getBoxForDate, I'd prefer changing that
> method to only accept a calIDateTime instead.

Actually there are others three callers. I've also changed to calIDateTime two of them.

Comment 4

[Decathlon]

Attachment: patch - v2 for checkin

Comment 5

[Patrick Cloke [:clokep]]

https://hg.mozilla.org/comm-central/rev/08168dc1fecf