Give kewisch access to mozilla/bedrock

RESOLVED WONTFIX

Status

www.mozilla.org
Bedrock
RESOLVED WONTFIX
3 years ago
3 years ago

People

(Reporter: Fallen, Unassigned)

Tracking

Production

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

3 years ago
as the Calendar owner I would like to be able to merge pull requests that simply change calendar data in mozilla/bedrock/media/caldata/ or make changes to the calendar

My github user is <https://github.com/kewisch/>. You can see I am the calendar module owner at <https://wiki.mozilla.org/Modules/Calendar>. I've put some webdev and Thunderbird folks on CC that might want to vouch for me if needed.

If this is not the right place to request access please let me know and/or forward accordingly.
Hi Philipp,

What is the reason for needing to be able to merge these PRs? I only ask because anyone can submit and review a pull-request, and while merging into master is a necessary step, the files won't go live on the site until we manually deploy to production. We usually like to keep merging permission on the core team so that we're all more aware of what is flowing into master since there are times when we need to freeze master while waiting for a large merge during a particularly sensitive deployment.

Are we not reviewing and merging PRs quickly enough? If not then we likely just didn't see them come in or didn't realize the priority, so in those cases feel free to ping us on IRC or needinfo me on a bug and we'll get right on it.
(Reporter)

Comment 2

3 years ago
Hi Paul, thanks for the reply. You are reviewing PRs fast enough and I am aware I can ask if needed, I just wanted to take the burden from you since the calendar stuff is probably not in your main focus. Its clear to me that if I have access, I will be making sure I follow the core team guidelines as well as possible and ask if in doubt.

Another reason I am asking is in preparation for the activities of the Thunderbird Council as per [1]. I'd like to see Thunderbird's website get off of SVN and into bedrock at some point and once that is done will likely be a slightly higher volume of changes than for calendar. Just to clarify, the initial move to bedrock would of course not be reviewed by me, I'm rather looking at subsequent changes: release notes and version specific webpages will need to be made live on specific days and for that it would be nice if we can shorten the waiting time and have control over when Thunderbird pages are made live.

Back when we moved the Calendar page to bedrock, it took an extremely long time from finished design to landing. It actually took multiple years because it seemed there was nothing I could do myself to push forward, I had to wait until there was time in the team for "legacy projects".

If you really would like to keep repository rights with the core team, maybe it would help to figure out more about the webdev process. Who are the folks we can ping if there is an "emergency" and we need to deploy something Thunderbird or Lightning related asap? How long does it usually take from sending a PR until the site is deployed? We will likely have more questions once we have actually moved to bedrock.

[1] https://groups.google.com/forum/#!topic/mozilla.governance/RwkVXjpqHzQ
(In reply to Philipp Kewisch [:Fallen] from comment #2)
> Hi Paul, thanks for the reply. You are reviewing PRs fast enough and I am
> aware I can ask if needed, I just wanted to take the burden from you since
> the calendar stuff is probably not in your main focus. Its clear to me that
> if I have access, I will be making sure I follow the core team guidelines as
> well as possible and ask if in doubt.

That is true, and we have no way of knowing whether the changes are good or not. But again, just to be clear, merging a PR to master will not get it into production. It will go live on www-dev.allizom.org within around 15 minutes, but production pushes are handled by the core bedrock team.

> Another reason I am asking is in preparation for the activities of the
> Thunderbird Council as per [1]. I'd like to see Thunderbird's website get
> off of SVN and into bedrock at some point and once that is done will likely
> be a slightly higher volume of changes than for calendar. Just to clarify,
> the initial move to bedrock would of course not be reviewed by me, I'm
> rather looking at subsequent changes: release notes and version specific
> webpages will need to be made live on specific days and for that it would be
> nice if we can shorten the waiting time and have control over when
> Thunderbird pages are made live.

That all sounds good. We'd all like for everything to be out of SVN and into bedrock :) The Release Notes specifically are currently being migrated into a database driven area of the site, so no code pushes should be required to get that done, and we will get you (and/or others) a login. 

> Back when we moved the Calendar page to bedrock, it took an extremely long
> time from finished design to landing. It actually took multiple years
> because it seemed there was nothing I could do myself to push forward, I had
> to wait until there was time in the team for "legacy projects".

It's true that the moving of the legacy site to bedrock has been slow. We've had to do a lot of new projects while still getting the old over. The site is of course open and we welcome contribution of ports of old pages or new features from anyone at any time, but it's true that we can only do so much. Smaller and on-going changes are much quicker to perform and review, and shouldn't be as large a deal. That said, the best way to expedite a change in bedrock is to open a pull-request. See our contribution docs[0] for more details.

> If you really would like to keep repository rights with the core team, maybe
> it would help to figure out more about the webdev process. 

We do want to do that, for some definitely of "core team". This does not mean employees only, but more people who wish to be regular contributors and have proved to be good stewards of the code and our standards. Until this status is reached, the best thing is to submit good pull-requests, and review other pull-requests. If you or someone else interested in the Thunderbird content wishes to contribute regularly to that section of the site then they'd be considered for inclusion in the team of commiters.

The team of people who can deploy the site to production is even smaller though, and inclusion in that group isn't likely.

> Who are the folks
> we can ping if there is an "emergency" and we need to deploy something
> Thunderbird or Lightning related asap? How long does it usually take from
> sending a PR until the site is deployed? We will likely have more questions
> once we have actually moved to bedrock.

If it's during normal Pacific time business hours there will usually be someone who can do a push in #www. That's typically myself (pmac), Josh Mize (jgmize), or Craig Cook (craigcook). If it's outside of that window and no one can be found in the #www channel, a bug for WebOps in the "Product Delivery" component would be the way to go.

Length of PR wait varies widely based on availablity of reviewers and complexity and quality of the PR. If it's a localized change of mostly HTML/CSS/JS then it shouldn't take more than a day or two for non-critical things. We have twice-weekly meetings to look as a group at pull-requests to try to ensure nothing falls through the cracks, but if you know a good person to review a PR we've found it best to just mention them in a comment on the PR and ask (e.g. "@pmclanahan r?").

I'm sure you'll have more questions. We're nearly always around and are happy to answer. Find us either here, in the #www channel on IRC, or on our public mailing list[1].

[0] http://bedrock.readthedocs.org/en/latest/contribute.html
[1] https://www.mozilla.org/en-US/about/forums/#dev-mozilla-org
(Reporter)

Comment 4

3 years ago
Thanks for the information, I think this will help us a lot when moving forward and reassures me that I'm in good hands with the webdev team :-) I'm going to close this WONTFIX and will handle things via IRC and pull requests for now.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.