Closed
Bug 1100883
Opened 10 years ago
Closed 10 years ago
Remove runnables from |BluetothServiceBluedroid|
Categories
(Firefox OS Graveyard :: Bluetooth, defect)
Firefox OS Graveyard
Bluetooth
Tracking
(Not tracked)
RESOLVED
FIXED
2.1 S9 (21Nov)
People
(Reporter: tzimmermann, Assigned: tzimmermann)
References
Details
Attachments
(4 files, 1 obsolete file)
13.10 KB,
patch
|
ben.tian
:
review+
|
Details | Diff | Splinter Review |
5.02 KB,
patch
|
ben.tian
:
review+
|
Details | Diff | Splinter Review |
4.77 KB,
patch
|
ben.tian
:
review+
|
Details | Diff | Splinter Review |
9.15 KB,
patch
|
tzimmermann
:
review+
|
Details | Diff | Splinter Review |
For historic reasons, |BluetoothServiceBluedroid| dispatches several runnables to the main thread for various operations. But all methods of |BluetoothServiceBluedroid| already run on the main thread, so the runnables' functionality can be called directly and the runnables can be removed.
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8524515 -
Flags: review?(btian)
Assignee | ||
Comment 3•10 years ago
|
||
Attachment #8524516 -
Flags: review?(btian)
Assignee | ||
Comment 4•10 years ago
|
||
Attachment #8524517 -
Flags: review?(btian)
Comment 5•10 years ago
|
||
Comment on attachment 8524514 [details] [diff] [review] [01] Bug 1100883: Move helpers of |BluetoothServiceBluedroid| into its namespace Review of attachment 8524514 [details] [diff] [review]: ----------------------------------------------------------------- LGTM.
Attachment #8524514 -
Flags: review?(btian) → review+
Comment 6•10 years ago
|
||
Comment on attachment 8524515 [details] [diff] [review] [02] Bug 1100883: Move |ToggleBtAck| into |BluetoothService| Review of attachment 8524515 [details] [diff] [review]: ----------------------------------------------------------------- LGTM.
Attachment #8524515 -
Flags: review?(btian) → review+
Comment 7•10 years ago
|
||
Comment on attachment 8524516 [details] [diff] [review] [03] Bug 1100883: Replace most instances of |ToggleBtAck| with calls to |AcknowledgeToggleBt| Review of attachment 8524516 [details] [diff] [review]: ----------------------------------------------------------------- LGTM.
Attachment #8524516 -
Flags: review?(btian) → review+
Comment 8•10 years ago
|
||
Comment on attachment 8524517 [details] [diff] [review] [04] Bug 1100883: Cleanup |BluetoothServiceBluedroid::AdapterStateChangedNotification| Review of attachment 8524517 [details] [diff] [review]: ----------------------------------------------------------------- r=me with comment addressed. Thanks! ::: dom/bluetooth/bluedroid/BluetoothServiceBluedroid.h @@ +26,5 @@ > class ProfileDeinitResultHandler; > class ProfileInitResultHandler; > class RemoveBondResultHandler; > class SetAdapterPropertyResultHandler; > + class SetAdapterPropertyResultHandler2; Rename to |SetAdapterDiscoverableResultHandler| to be more specific.
Attachment #8524517 -
Flags: review?(btian) → review+
Assignee | ||
Comment 9•10 years ago
|
||
Changes since v1: - fixed class naming
Attachment #8524517 -
Attachment is obsolete: true
Attachment #8525929 -
Flags: review+
Assignee | ||
Comment 10•10 years ago
|
||
Thanks, Ben! https://hg.mozilla.org/integration/b2g-inbound/rev/3053c1e82a97 https://hg.mozilla.org/integration/b2g-inbound/rev/9b41f221045c https://hg.mozilla.org/integration/b2g-inbound/rev/cf0307b3c1ae https://hg.mozilla.org/integration/b2g-inbound/rev/fe7bf846e967 https://treeherder.mozilla.org/ui/#/jobs?repo=b2g-inbound&revision=fe7bf846e967
https://hg.mozilla.org/mozilla-central/rev/3053c1e82a97 https://hg.mozilla.org/mozilla-central/rev/9b41f221045c https://hg.mozilla.org/mozilla-central/rev/cf0307b3c1ae https://hg.mozilla.org/mozilla-central/rev/fe7bf846e967
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.1 S9 (21Nov)
No longer blocks: 1102885
You need to log in
before you can comment on or make changes to this bug.
Description
•