Closed Bug 1100883 Opened 6 years ago Closed 6 years ago

Remove runnables from |BluetothServiceBluedroid|

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
2.1 S9 (21Nov)

People

(Reporter: tzimmermann, Assigned: tzimmermann)

References

Details

Attachments

(4 files, 1 obsolete file)

For historic reasons, |BluetoothServiceBluedroid| dispatches several runnables to the main thread for various operations. But all methods of |BluetoothServiceBluedroid| already run on the main thread, so the runnables' functionality can be called directly and the runnables can be removed.
Assignee: nobody → tzimmermann
Status: NEW → ASSIGNED
Attachment #8524514 - Flags: review?(btian)
Comment on attachment 8524514 [details] [diff] [review]
[01] Bug 1100883: Move helpers of |BluetoothServiceBluedroid| into its namespace

Review of attachment 8524514 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8524514 - Flags: review?(btian) → review+
Comment on attachment 8524515 [details] [diff] [review]
[02] Bug 1100883: Move |ToggleBtAck| into |BluetoothService|

Review of attachment 8524515 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8524515 - Flags: review?(btian) → review+
Comment on attachment 8524516 [details] [diff] [review]
[03] Bug 1100883: Replace most instances of |ToggleBtAck| with calls to |AcknowledgeToggleBt|

Review of attachment 8524516 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8524516 - Flags: review?(btian) → review+
Comment on attachment 8524517 [details] [diff] [review]
[04] Bug 1100883: Cleanup |BluetoothServiceBluedroid::AdapterStateChangedNotification|

Review of attachment 8524517 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with comment addressed. Thanks!

::: dom/bluetooth/bluedroid/BluetoothServiceBluedroid.h
@@ +26,5 @@
>    class ProfileDeinitResultHandler;
>    class ProfileInitResultHandler;
>    class RemoveBondResultHandler;
>    class SetAdapterPropertyResultHandler;
> +  class SetAdapterPropertyResultHandler2;

Rename to |SetAdapterDiscoverableResultHandler| to be more specific.
Attachment #8524517 - Flags: review?(btian) → review+
Changes since v1:

  - fixed class naming
Attachment #8524517 - Attachment is obsolete: true
Attachment #8525929 - Flags: review+
You need to log in before you can comment on or make changes to this bug.