If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Don't smooth scroll tab strip when restoring tabs on startup

RESOLVED FIXED in Firefox 36

Status

()

Firefox for Android
General
P1
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: lucasr, Assigned: lucasr)

Tracking

unspecified
Firefox 36
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

3 years ago
We should simply move the tab strip to the proper position.
(Assignee)

Updated

3 years ago
Priority: -- → P1
(Assignee)

Comment 1

3 years ago
Created attachment 8524526 [details] [diff] [review]
Remove unused imports from TabStripView (r=mcomella)
(Assignee)

Comment 2

3 years ago
Created attachment 8524527 [details] [diff] [review]
Don't smooth scroll when restoring tabs on startup (r=mcomella)
(Assignee)

Updated

3 years ago
Attachment #8524526 - Flags: review?(michael.l.comella)
(Assignee)

Updated

3 years ago
Attachment #8524527 - Flags: review?(michael.l.comella)
Attachment #8524526 - Flags: review?(michael.l.comella) → review+
Comment on attachment 8524527 [details] [diff] [review]
Don't smooth scroll when restoring tabs on startup (r=mcomella)

Review of attachment 8524527 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/tabs/TabStripView.java
@@ +223,5 @@
>  
>      private void ensurePositionIsVisible(final int position) {
> +        // We just want to move the strip to the right position
> +        // when restoring tabs on startup.
> +        if (isRestoringTabs) {

I'd rather have this get passed as a parameter, but this looks like it works.

The default methods, e.g. `refreshTabs()`, can call out to `refreshTabs(boolean isRestoringTabs)` with a default value to avoid a large amount of changes.
Attachment #8524527 - Flags: review?(michael.l.comella) → review+
(Assignee)

Comment 4

3 years ago
(In reply to Michael Comella (:mcomella) from comment #3)
> Comment on attachment 8524527 [details] [diff] [review]
> Don't smooth scroll when restoring tabs on startup (r=mcomella)
> 
> Review of attachment 8524527 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: mobile/android/base/tabs/TabStripView.java
> @@ +223,5 @@
> >  
> >      private void ensurePositionIsVisible(final int position) {
> > +        // We just want to move the strip to the right position
> > +        // when restoring tabs on startup.
> > +        if (isRestoringTabs) {
> 
> I'd rather have this get passed as a parameter, but this looks like it works.
> 
> The default methods, e.g. `refreshTabs()`, can call out to
> `refreshTabs(boolean isRestoringTabs)` with a default value to avoid a large
> amount of changes.

Fair point but it ends up looking more complicated due to the all boolean passing between methods.
(Assignee)

Comment 5

3 years ago
https://hg.mozilla.org/integration/fx-team/rev/915b53f26a53
https://hg.mozilla.org/mozilla-central/rev/915b53f26a53
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
You need to log in before you can comment on or make changes to this bug.