1100895 - [Telephony] add a promise attribute for ready event

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Szu-Yu Chen [:aknow] (inactive)]

We now have a "ready" event on Telephony [1] to signal that the object is ready and the data inside is initialize properly.

I found that a better way to achieve the same purpose is to have a read only promise attribute.

interface Telephony {                                  
  [Throws]                                           
  readonly attribute Promise<void> ready; // or loaded
};    

Then we could use mozTelephony.ready.then(...)

AFAIK, ready event is not yet used in gaia code. Maybe now is a good chance to modify it.

[1] http://dxr.mozilla.org/mozilla-central/source/dom/webidl/Telephony.webidl?from=Telephony.webidl&case=true#50

Comment 1

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: Part 1: Replace 'ready' event by a readonly attribute 'ready'

Comment 2

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: Part 2: Implement ready attribute

Comment 3

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: Part 3: Modify test

Comment 4

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8527514 [details] [diff] [review]
Part 1: Replace 'ready' event by a readonly attribute 'ready'

Review of attachment 8527514 [details] [diff] [review]:
-----------------------------------------------------------------

The change makes much more sense, thank you!

Comment 5

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8527515 [details] [diff] [review]
Part 2: Implement ready attribute

Review of attachment 8527515 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you!

Comment 6

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8527516 [details] [diff] [review]
Part 3: Modify test

Review of attachment 8527516 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 7

[Szu-Yu Chen [:aknow] (inactive)]

try looks good
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=70977566b54a

Comment 8

[Szu-Yu Chen [:aknow] (inactive)]

https://hg.mozilla.org/integration/b2g-inbound/rev/455d0c0c339d
https://hg.mozilla.org/integration/b2g-inbound/rev/7fe086e9bf7e
https://hg.mozilla.org/integration/b2g-inbound/rev/301c6c59cebf

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/455d0c0c339d
https://hg.mozilla.org/mozilla-central/rev/7fe086e9bf7e
https://hg.mozilla.org/mozilla-central/rev/301c6c59cebf