1100903 - Batch redis commands wherever possible

Status: RESOLVED FIXED

(Hello (Loop) :: Server, defect, P1)

Description

[Mike de Boer [:mikedeboer]]

There are quite a couple of places in loop/storage/redis.js that can benefit from using the Redis MULTI command to batch calls:

`deleteUserCallUrls`, `deleteUserCalls`, `getUserCalls`, `incrementConnectedCallDevices`, `decrementConnectedCallDevices`, `getCall`, `touchHawkSession`, `setUserRoomData`, `getUserRooms`, `touchRoomParticipant`, `deleteRoomParticipant`.

I know that certain functions use  async.map to call into other member functions that do some processing, but one way to migrate from that is to have these functions optionally return commands instead of executing them. These commands can then be concatenated and passed to _client.multi().

This will dramatically improve performance, I think, by lowering the overhead of socket traffic and more efficient redis task scheduling.

Comment 1

[Rémy Hubscher (:natim)]

Good point, thanks.

Comment 2

[Rémy Hubscher (:natim)]

Attachment: Link to Github PR — #267.

Comment 3

[Rémy Hubscher (:natim)]

Apparently I still need to work on:

 - getUserCalls
 - getCall

mikedeboer — getUserRooms seems clean to me, where could we use multi?

Comment 4

[Mike de Boer [:mikedeboer]]

(In reply to Rémy Hubscher (:natim) from comment #3)
> mikedeboer — getUserRooms seems clean to me, where could we use multi?

`getUserRooms` also looks good to, please scratch it from the list ;)

Comment 5

[Rémy Hubscher (:natim)]

Do you see anything we could benefit from?

Comment 6

[Mike de Boer [:mikedeboer]]

Comment on attachment 8542160 [details] [review]
Link to Github PR — #267.

Awesome! I foresee much win having this in, thanks!

Comment 7

[Alexis Metaireau (:alexis)]

Comment on attachment 8542160 [details] [review]
Link to Github PR — #267.

This just landed with https://github.com/mozilla-services/loop-server/commit/25d4029cbef215af1bfcb1192d395880975a9f5c, awesome :)