1100916 - [User Story] As a Helper, I can see a list of help requests, so that I can decide which request I want to address

Status: VERIFIED FIXED

(support.mozilla.org :: BuddyUp, defect)

Description

[Kadir Topal [:atopal]]

As a Helper, I can see a list of help requests, so that I can decide which request I want to address.

Comment 1

[Schalk Neethling [:espressive]]

Quick question:

"Helper can select between “New” or “Active” to display 2 separate lists. This user story addresses the “new” list" - Does new mean, no comments at all or, just that the question has not been solved?

Comment 2

[Romain Testard [:RT]]

Originally I had "Have not been commented on yet by any helper". Although this leave the door open for questions where a helper would have posted a comment although not provided enough details to the helpee and then lost interest.

Although now I am thinking that it should rather be:
* Not taken by another helper
* AND Not resolved
* AND The last comment on the discussion thread has been submitted by the helpee - if there is a comment (indicates that the helpee wants more)

Seems right?
I NI Kadir for further thoughts there.

Comment 3

[Schalk Neethling [:espressive]]

So, there is a lot going on in terms of the acceptance criteria for this bug. I am therefore going to split some of those out into separate bugs so that we do not run into the situation where one needs to open a *huge* pull request that touches a ton of files etc, making working in tandem harder.

I will mark all the individual bugs as blockers for this one to be resolved. I am therefore also reopening this one.

Comment 4

[Schalk Neethling [:espressive]]

"- Have not been commented on yet by any helper
Displayed in anti-chronological order - most recently updated on top"

So this says that new questions are those where no comments have been posted, good but, it also sounds like a helpee can in fact comment on a question they have asked, before any helpers has commented. Am I correct here?

If so, then I would assume the following line is not completely accurate:
"number of additional comments (will always be 0)"

Comment 5

[Schalk Neethling [:espressive]]

Code for the first part of this lives here for now:
https://github.com/ossreleasefeed/buddyup/tree/bug1100916-answer-a-question-helper

Comment 6

[Schalk Neethling [:espressive]]

Attachment: https://github.com/mozilla/buddyup/pull/37

Comment 7

[Anthony Ricaud (:rik)]

Comment on attachment 8535765 [details] [review]
https://github.com/mozilla/buddyup/pull/37

I've left my comments on the pull request.

Comment 8

[Anthony Ricaud (:rik)]

Comment on attachment 8535765 [details] [review]
https://github.com/mozilla/buddyup/pull/37

Please address the three comments I left and squash the commits before landing.

Comment 9

[Kadir Topal [:atopal]]

(In reply to Romain Testard [:RT] from comment #2)
> Originally I had "Have not been commented on yet by any helper". Although
> this leave the door open for questions where a helper would have posted a
> comment although not provided enough details to the helpee and then lost
> interest.
> 
> Although now I am thinking that it should rather be:
> * Not taken by another helper
> * AND Not resolved
> * AND The last comment on the discussion thread has been submitted by the
> helpee - if there is a comment (indicates that the helpee wants more)
> 
> Seems right?
> I NI Kadir for further thoughts there.

Yes, your description is correct, otherwise we'd be completely binding a thread to a single contributor, but we want others to jump in if the first one is not ready for whatever reason. I'll change the user story accordingly.



(In reply to Schalk Neethling [:espressive] from comment #4)
> "- Have not been commented on yet by any helper
> Displayed in anti-chronological order - most recently updated on top"
> 
> So this says that new questions are those where no comments have been
> posted, good but, it also sounds like a helpee can in fact comment on a
> question they have asked, before any helpers has commented. Am I correct
> here?
> 
> If so, then I would assume the following line is not completely accurate:
> "number of additional comments (will always be 0)"

Correct, new should include all cases where the helpee is the last to post, either because there was no other comment, or because the helpee came back and gave us more info, etc.


As a side note, this still creates an issue where threads essentially become invisible once a helper has replied to them. The reply might be of low quality or not helpful, but unless the helpee comes back, those threads will only be visible the to the first helper. I think we'll just accept that for now.