110093 - add indicator for image manager state to Media tab

Status: RESOLVED DUPLICATE of bug 110075

(SeaMonkey :: Page Info, enhancement)

Description

[Quinn Yost (mythdraug)]

Image info should contain some indication of an image's
status within the Image Manager.  I'm thinking red x for
site is blocked, green check for permitted, grey ? for
ask.

Comment 1

[sairuh (rarely reading bugmail)]

->daniel and confirming rfe.

Comment 2

[Daniel Brooks [:db48x]]

I think what I'll do is set this column up, then make it so that clicking on
this column toggles the state for the image, kind like you can do in mail for
some of the flags in the outliner there. 

However, I'm not sure what the grey question mark icon would represent, perhaps
that the state hasn't been queried yet or something?

Comment 3

[Adam Hauner]

Plat, OS: --> All

Comment 4

[Quinn Yost (mythdraug)]

Sorry for the confusion on the question mark.
I was seeing it representing an image site that
did not exist in cookperm.txt (ie the user
accepted or denied the image but did not ask
mozilla to remember the choice). 

Comment 5

[sairuh (rarely reading bugmail)]

mass moving open bugs pertaining to page info to [e-mail] as qa contact.

to find all bugspam pertaining to this, set your search string to
"BigBlueDestinyIsHere".

Comment 6

[Wesha]

Attachment: Very alpha patch; please submit your comments!

What would you say about this?
("Status:" field should appear right below the URL on the Media tab, which says
"Blocked" if the image is blocked).

HOWEVER: I wanted to also add "Not Found" if the image is not found. Does
anybody know what flag/condition/etc should be checked to do so?

Comment 7

[Daniel Brooks [:db48x]]

Comment on attachment 104331 [details] [diff] [review]
Very alpha patch; please submit your comments!

Good start. I think however that instead of adding a row to the preview area,
we need a new column in the tree area.

Basically, to add a column you need to add it to the xul file, then add the id
to the list at the top of pageinfo.js, where imageView is declared. Then in
grabAll() you can check the status and add the information to the tree. You'll
probably need to add a way to specify an image in the addRow() function, though
it might be easier to just put an empty string there, and then have it call
setCellImage() [which would need ot be defined of course] seperatly.

>+  <!-- We need cookieOverlay.js because it contains IMAGEPERMISSION constant. --> 
>+  <script type="application/x-javascript" src="chrome://cookie/content/cookieOverlay.js"/>

it would probably be better to just copy the constant.

Comment 8

[Wesha]

The general idea for adding a row was to have a flag having "OK / Blocked /
Broken / Not found at given URL" states. And I don't think it'll be a problem to
add such a column to the table too. I will work on it; this was a quick patch I
fixed in a few minutes.

>+  <!-- We need cookieOverlay.js because it contains IMAGEPERMISSION constant. 
>it would probably be better to just copy the constant.

And what if somebody changes that constant in cookieOverlay.js and forgets to
change it here? Then we'll get yet another misterious bug.


P.S. Anybody can give me an advice on how to figure out if the image is a)
broken and b) not found at given URL?

Comment 10

[Quinn Yost (mythdraug)]

Wow Philip.     Don't you think this would have been marked as a Dupe of my own bug at some other time in the last 7 years?