Closed Bug 1100930 Opened 10 years ago Closed 9 years ago

[Contacts] Search for contacts with quotes is not working

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Contacts
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.2 affected, b2g-master verified)

Status:
VERIFIED FIXED
Milestone:
2.2 S4 (23jan)
Tracking Flags:
Tracking Status
b2g-v2.2 --- affected
b2g-master --- verified

People

(Reporter: hola, Assigned: hola)

References

Details

Attachments

(3 files)

Search contact list with contacts with quotes
62.04 KB, image/png
Details
Searching for double quotes return no contacts (the same happens with single quotes)
38.07 KB, image/png
Details
Pull request
46 bytes, text/x-github-pull-request
arcturus
: review+
crdlc
: feedback+
Details | Review 
If a contact has " or ' in her name, the user is unable to search for the contact using those characters.
Assignee: nobody → hola
Attached file Pull request — 
Not every normalized html character was being turned again into the real character, because quotes were missing.
Attachment #8524612 - Flags: review?(jmcf)
Comment on attachment 8524612 [details] [review]
Pull request

cancelling review as we need more work. Tests are missing and we need to move code to shared. 

But that should be done once bug 1088706
Attachment #8524612 - Flags: review?(jmcf)
Comment on attachment 8524612 [details] [review]
Pull request

Test added.
Attachment #8524612 - Flags: review?(francisco)
Attachment #8524612 - Flags: feedback?(crdlc)
Comment on attachment 8524612 [details] [review]
Pull request

LGTM, left a comment, thanks
Attachment #8524612 - Flags: feedback?(crdlc) → feedback+
Blocks: 1104139
Adrian, can we add unit test to this?
Flags: needinfo?(hola)
Oops, sorry, I messed up with my repo, but I recovered the last version. Tests are added now!
Flags: needinfo?(hola)
Comment on attachment 8524612 [details] [review]
Pull request

Working great, sorry for taking that long :(
Attachment #8524612 - Flags: review?(francisco) → review+
Keywords: checkin-needed
Master: https://github.com/mozilla-b2g/gaia/commit/6d88406486009241317e429ccfd1d8fe1a02470a
Status: NEW → RESOLVED
Closed: 9 years ago
status-b2g-master: --- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S4 (23jan)
This issue is verified fixed on Flame Master.

Result: 
 
Device: Flame Master (319mb, full flash)
Build ID: 20150122010203
Gaia: 917b6c36717fddc6e71ffc1ec249633c8044c93c
Gecko: 34e2d2bd7ec4
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (Master)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0
=======================================================
Marking status-b2g-v2.2 as affected. The original bug was written on 2.2, which needs to be fixed as well.

Device: Flame 2.2 (319mb, full flash)
BuildID: 20150122002808
Gaia: e4f9b5da3751798f9cc5d95f302c30722cc11fca
Gecko: 4a90da67661e
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2)
Firmware: V18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage?]
status-b2g-v2.2: --- → affected
status-b2g-master: fixed → verified
Flags: needinfo?(ktucker)
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: