1100942 - Attachment links in request.cgi should go to the attachment and not default to &action=edit

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, enhancement)

Description

[(not currently active) Ted Mielczarek]

I go through my review queue using request.cgi. The attachment links on there all link to the attachment with &action=edit in the URL. For patch attachments there's also a [Review] link that takes me to the Splinter view, which is what I've historically used. In this modern era of ReviewBoard and GitHub issues, however, that doesn't exist, and clicking the attachment link is not useful. It would be nice if those could just link directly to the RB/GH issue.

Comment 1

[David Lawrence [:dkl]]

Lets work this upstream as I think it would be useful there as well to be able to differentiate the two actions.

I propose that when you click on the attachment id, it should take you to the raw attachment similar to what happens on show_bug.cgi for attachments. Then add a [details] link next to it that will take you to the action=edit page.

Just as an added note related to BMO, after this patch is implemented, when clicking on the attachment link, if the attachment data is a reviewboard URL, it will automatically redirect. Which will solve the original request with this bug.

dkl

Comment 2

[David Lawrence [:dkl]]

Attachment: 1100942_1.patch

Comment 3

[Gervase Markham [:gerv]]

Comment on attachment 8524763 [details] [diff] [review]
1100942_1.patch

Review of attachment 8524763 [details] [diff] [review]:
-----------------------------------------------------------------

r=gerv.

Gerv

Comment 4

[David Lawrence [:dkl]]

To ssh://[e-mail]/bugzilla/bugzilla.git
   47da91d..259615d  master -> master