Closed Bug 1100988 Opened 5 years ago Closed 2 years ago

Remove useless observer in nsIPrintingPromptService::showPageSetup

Categories

(Core :: Printing: Setup, defect)

32 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla60
Tracking Status
firefox60 --- fixed

People

(Reporter: mconley, Assigned: gsvelto)

Details

Attachments

(1 file)

nsIPrintingPromptService's ShowPageSetup method takes an observer, which is never used. I think we should probably just remove it.
Just came across this while looking at observers, taking it.
Assignee: nobody → gsvelto
Status: NEW → ASSIGNED
Comment on attachment 8948337 [details]
Bug 1100988 - Remove useless observer parameter in nsIPrintingPromptService.showPageSetup();

https://reviewboard.mozilla.org/r/217822/#review223728

\o/ Thanks!
Attachment #8948337 - Flags: review?(mconley) → review+
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fc3d9de1f56c
Remove useless observer parameter in nsIPrintingPromptService.showPageSetup(); r=mconley
https://hg.mozilla.org/mozilla-central/rev/fc3d9de1f56c
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
You need to log in before you can comment on or make changes to this bug.