Closed
Bug 1101001
Opened 10 years ago
Closed 10 years ago
Stop checking for compileAndGo in GetPCCountScriptContents
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(1 file)
946 bytes,
patch
|
bhackett1024
:
review+
|
Details | Diff | Splinter Review |
Doesn't seem like there's a good reason for it.
Assignee | ||
Comment 1•10 years ago
|
||
This seems a bit weird in that it makes us return the empty string in _more_ cases. Specifically, we used to not do that when the script was compileAndGo but now we will? What's the real goal of this early return?
Attachment #8524667 -
Flags: review?(bhackett1024)
Comment 2•10 years ago
|
||
Comment on attachment 8524667 [details] [diff] [review] Stop checking compileAndGo in GetPCCountScriptContents Review of attachment 8524667 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/jsopcode.cpp @@ +2397,1 @@ > return buf.finishString(); I think it would be better to just delete this |if| statement entirely. This now has the effect of not getting PC counts for any global scripts, which we don't want to happen. I vaguely remember there being some issue with global non-CNG scripts when I originally wrote this but don't remember what it is. But there isn't any intrinsic reason why we should discriminate between scripts with and without functions here.
Attachment #8524667 -
Flags: review?(bhackett1024) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Makes sense. https://hg.mozilla.org/integration/mozilla-inbound/rev/e20b1f0d5763
Target Milestone: --- → mozilla36
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e20b1f0d5763
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•