Investigate Win32-only paint suppression weirdness

NEW
Unassigned

Status

()

Core
Layout
17 years ago
8 years ago

People

(Reporter: David Hyatt, Unassigned)

Tracking

({perf})

Trunk
mozilla1.2alpha
x86
Windows 2000
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

17 years ago
I need to explore the paint suppression implementation a bit.  Some pages are
staying suppressed way too long, and I need to figure out the cause (timers,
message priorities out of whack, bugs in the actual paint suppression code, etc.).
(Reporter)

Updated

17 years ago
Status: NEW → ASSIGNED
(Reporter)

Updated

17 years ago
Target Milestone: --- → mozilla0.9.7
(Reporter)

Updated

17 years ago
Target Milestone: mozilla0.9.7 → mozilla0.9.8
(Reporter)

Updated

17 years ago
Target Milestone: mozilla0.9.8 → mozilla0.9.9
(Reporter)

Updated

17 years ago
Target Milestone: mozilla0.9.9 → mozilla1.2

Comment 1

16 years ago
David, this is the fix, or at least a fix.....

In: layout\html\base\src\nsPresShell.cpp
     In: PresShell::UnsuppressAndInvalidate()

...
      if (cv) {
        nsCOMPtr<nsIPresShell> kungFuDeathGrip(this);
        mPaintingSuppressed = PR_FALSE;  /* Added by SLE to cause Show() to be
actually effective !! */
        cv->Show();
        // Calling |Show| may destroy us.  Not sure why yet, but it's
        // a smoketest blocker.
        if (mIsDestroying)
          return;
      }
...

Thanks!
Sam

Updated

16 years ago
Keywords: mozilla1.0, perf

Updated

16 years ago
Depends on: 142635
The comment above was filed as bug 142635.

Updated

16 years ago
Keywords: mozilla1.0 → mozilla1.3
QA Contact: chrispetersen → layout

Updated

9 years ago
Assignee: hyatt → nobody
This is a mass change. Every comment has "assigned-to-new" in it.

I didn't look through the bugs, so I'm sorry if I change a bug which shouldn't be changed. But I guess these bugs are just bugs that were once assigned and people forgot to change the Status back when unassigning.
Status: ASSIGNED → NEW

Comment 4

8 years ago
(In reply to comment #0)
> I need to explore the paint suppression implementation a bit.  Some pages are
> staying suppressed way too long, and I need to figure out the cause (timers,
> message priorities out of whack, bugs in the actual paint suppression code, etc.).

Based on the complete lack of activity it seems like this could be closed. Or does this still need exploration?
You need to log in before you can comment on or make changes to this bug.