js_DumpBacktrace should dump all frames

RESOLVED FIXED in mozilla36

Status

()

Core
JavaScript Engine
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: billm, Assigned: billm)

Tracking

unspecified
mozilla36
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

971 bytes, patch
Bobby Holley (parental leave - send mail for anything urgent)
: review+
nbp
: review+
Details | Diff | Splinter Review
(Assignee)

Description

3 years ago
Created attachment 8524757 [details] [diff] [review]
dump-backtrace

It looks like DumpJSStack already does this. However, that function doesn't accept an arbitrary context and it also segfaults when we're using CPOWs (since it tries to call toString on them, which does an IPC).
Attachment #8524757 - Flags: review?(bobbyholley)
Comment on attachment 8524757 [details] [diff] [review]
dump-backtrace

Review of attachment 8524757 [details] [diff] [review]:
-----------------------------------------------------------------

Sounds good to me.
Attachment #8524757 - Flags: review+
We should fix the crash bit, at least.  DumpJSStack is a very commonly used tool in debugging Firefox, and having it randomly explode is not so great.
Attachment #8524757 - Flags: review?(bobbyholley) → review+
(Assignee)

Comment 3

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/d99caaf9ab8c
https://hg.mozilla.org/mozilla-central/rev/d99caaf9ab8c
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in before you can comment on or make changes to this bug.