Closed
Bug 1101083
Opened 10 years ago
Closed 10 years ago
js_DumpBacktrace should dump all frames
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: billm, Assigned: billm)
Details
Attachments
(1 file)
971 bytes,
patch
|
bholley
:
review+
nbp
:
review+
|
Details | Diff | Splinter Review |
It looks like DumpJSStack already does this. However, that function doesn't accept an arbitrary context and it also segfaults when we're using CPOWs (since it tries to call toString on them, which does an IPC).
Attachment #8524757 -
Flags: review?(bobbyholley)
Comment 1•10 years ago
|
||
Comment on attachment 8524757 [details] [diff] [review] dump-backtrace Review of attachment 8524757 [details] [diff] [review]: ----------------------------------------------------------------- Sounds good to me.
Attachment #8524757 -
Flags: review+
Comment 2•10 years ago
|
||
We should fix the crash bit, at least. DumpJSStack is a very commonly used tool in debugging Firefox, and having it randomly explode is not so great.
Updated•10 years ago
|
Attachment #8524757 -
Flags: review?(bobbyholley) → review+
Assignee | ||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/d99caaf9ab8c
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/d99caaf9ab8c
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
You need to log in
before you can comment on or make changes to this bug.
Description
•