Closed
Bug 1101162
Opened 10 years ago
Closed 10 years ago
switchToTabHavingURI's replaceQueryString should not be passed to openUILinkIn as part of aOpenParams
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
FIXED
Firefox 37
People
(Reporter: jaws, Assigned: l0p3s222, Mentored)
References
Details
(Whiteboard: [good first bug][lang=js])
Attachments
(1 file)
|
1.26 KB,
patch
|
jaws
:
review+
|
Details | Diff | Splinter Review |
replaceQueryString was added by bug 1053939, and it should have been deleted from aOpenParams after it was pulled out. openUILinkIn doesn't use this, and we shouldn't expand the API for something that is only destined for switchToTabHavingURI.
See http://hg.mozilla.org/mozilla-central/annotate/084441e904d1/browser/base/content/browser.js#l7353.
|
||
Updated•10 years ago
|
Mentor: jaws
|
Reporter | |
Updated•10 years ago
|
Whiteboard: [good first bug][lang=js]
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → l0p3s222
|
|
Reporter | |
Comment 2•10 years ago
|
||
Comment on attachment 8538262 [details] [diff] [review]
delete the unused property
Review of attachment 8538262 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good! Thanks for the patch :)
Attachment #8538262 -
Flags: review?(jaws) → review+
|
|
Reporter | |
Comment 3•10 years ago
|
||
This doesn't need a try push since it is just removing the property and the property isn't being used elsewhere.
Status: NEW → ASSIGNED
Keywords: checkin-needed
|
||
Comment 4•10 years ago
|
||
Keywords: checkin-needed
Whiteboard: [good first bug][lang=js] → [good first bug][lang=js][fixed-in-fx-team]
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug][lang=js][fixed-in-fx-team] → [good first bug][lang=js]
Target Milestone: --- → Firefox 37
You need to log in
before you can comment on or make changes to this bug.
Description
•