1101192 - [email/UI] Improve accessibility of the manual settings within the new email account.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Yura Zenevich [:yzen] (please use "needinfo")]

Overall looks good just a couple of fixes related to:
* Labeling of the back button in the header
* Labeling of all drop downs: account type, security.

Comment 1

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Github pull request.

Comment 2

[James Burke [:jrburke]]

Comment on attachment 8524881 [details] [review]
Github pull request.

Thanks for looking into this! I have some comments in the pull request, mainly related to the styles of IDs/class relationships used in email. Feel free to flip review back to me when addressed. If you have questions on the comments, I will respond to them in the pull request.

Comment 3

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8524881 [details] [review]
Github pull request.

Hopefully, addressed all the comments. Given that we can only reference ID's in the aria-labelledby, aria-describedby, etc, I opted for using a new aria-label for the select instead of markup tweaks.

Comment 4

[James Burke [:jrburke]]

Comment on attachment 8524881 [details] [review]
Github pull request.

This is looking really good, just some nits in the locale file, flip review back to me when done.

Comment 5

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8524881 [details] [review]
Github pull request.

Hopefully all suggestions are taken care of.

Comment 6

[James Burke [:jrburke]]

Comment on attachment 8524881 [details] [review]
Github pull request.

Looks great, thank you! Happy to see the better accessibility landing!

Comment 7

[Yura Zenevich [:yzen] (please use "needinfo")]

https://github.com/mozilla-b2g/gaia/commit/c18773452502102ae59076710ca51f841832c677