Closed
Bug 1101195
Opened 10 years ago
Closed 10 years ago
gfxUtils::EncodeSourceSurface is broken (breaks gfxUtils::WriteAsPNG, gfxUtils::DumpAsDataURL)
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla36
People
(Reporter: mstange, Assigned: mstange)
References
Details
(Keywords: regression)
Attachments
(1 file)
991 bytes,
patch
|
jwatt
:
review+
lmandel
:
approval-mozilla-aurora+
lmandel
:
approval-mozilla-beta-
|
Details | Diff | Splinter Review |
Bug 1076910 added this line: NS_ENSURE_TRUE(!imgData.empty(), NS_ERROR_FAILURE); But the Vector<char> imgData is never resized, its length is always zero. We only set its capacity and read data into it. So since that change we always error out and never save any PNG data. This patch updates the length after reading into the vector.
Attachment #8524880 -
Flags: review?(jwatt)
Assignee | ||
Comment 1•10 years ago
|
||
[Tracking Requested - why for this release]: This caused bug 1098130 and has a very simple fix.
status-firefox33:
--- → wontfix
status-firefox34:
--- → affected
status-firefox35:
--- → affected
status-firefox36:
--- → affected
tracking-firefox34:
--- → ?
tracking-firefox35:
--- → ?
tracking-firefox36:
--- → ?
Comment 2•10 years ago
|
||
Comment on attachment 8524880 [details] [diff] [review] patch Oops. Sorry you had to debug this. :(
Attachment #8524880 -
Flags: review?(jwatt) → review+
Assignee | ||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/750dab541df3
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8524880 [details] [diff] [review] patch Approval Request Comment [Feature/regressing bug #]: regression from bug 1076910 [User impact if declined]: blank jumplist favicons (bug 1098130) + harder debugging [Describe test coverage new/current, TBPL]: none, this is mostly a debugging tool [Risks and why]: very low, extremely simple patch [String/UUID change made/needed]: none
Attachment #8524880 -
Flags: approval-mozilla-beta?
Attachment #8524880 -
Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/750dab541df3
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla36
Updated•10 years ago
|
Comment 6•10 years ago
|
||
Comment on attachment 8524880 [details] [diff] [review] patch We shipped with the jumplist icons issue in 33. I think we can reasonably ship with the issue again in 34. As it's very late in Beta, let's take this in 35. Beta- Aurora+
Attachment #8524880 -
Flags: approval-mozilla-beta?
Attachment #8524880 -
Flags: approval-mozilla-beta-
Attachment #8524880 -
Flags: approval-mozilla-aurora?
Attachment #8524880 -
Flags: approval-mozilla-aurora+
Updated•10 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•