Closed
Bug 1101196
Opened 10 years ago
Closed 9 years ago
Showing the event listeners on twitter.com doesn't work
Categories
(DevTools :: Debugger, defect)
DevTools
Debugger
Tracking
(firefox36 wontfix, firefox37 fixed, firefox38 fixed, firefox38.0.5 verified, firefox39 verified, firefox40 verified, firefox41 verified)
VERIFIED
FIXED
Firefox 39
People
(Reporter: jrmuizel, Assigned: past)
References
Details
(Whiteboard: [bugday-20150610])
Attachments
(1 file)
2.47 KB,
patch
|
vporof
:
review+
lmandel
:
approval-mozilla-aurora+
lmandel
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
STR: Open the event listener pane in the debugger. Nothing shows up.
Jeff, do you still see this issue? Are you using e10s? I am able to see a event listeners on the page here. However I did have trouble with DuckDuckGo, in e10s only. I filed bug 1106692 about it.
Flags: needinfo?(jmuizelaar)
See Also: → 1106692
Assignee | ||
Comment 2•9 years ago
|
||
I just tried on a nightly with e10s enabled and I got the following stack trace: Full Message: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIStringBundle.GetStringFromName] Full Stack: JS frame :: resource:///modules/devtools/ViewHelpers.jsm :: ViewHelpers.L10N.prototype.getStr :: line 331 JS frame :: chrome://browser/content/devtools/debugger-panes.js :: EventListenersView.prototype<.addListener :: line 2521 JS frame :: chrome://browser/content/devtools/debugger-controller.js :: EventListeners.prototype._getListeners/< :: line 1754 JS frame :: self-hosted :: next :: line 911 JS frame :: resource://gre/modules/Task.jsm :: TaskImpl_run :: line 314 JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js :: resolve :: line 40 JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js :: then :: line 20 JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/deprecated-sync-thenables.js :: resolve :: line 72 JS frame :: chrome://browser/content/devtools/debugger-controller.js :: EventListeners.prototype._getDefinitionSite/< :: line 1784 JS frame :: resource://gre/modules/devtools/dbg-client.jsm :: DebuggerClient.requester/</< :: line 348 JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js :: makeInfallible/< :: line 83 JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/event/core.js :: emit :: line 97 JS frame :: resource://gre/modules/devtools/dbg-client.jsm :: Request.prototype.emit :: line 1099 JS frame :: resource://gre/modules/devtools/dbg-client.jsm :: DebuggerClient.prototype.onPacket :: line 939 JS frame :: resource://gre/modules/devtools/dbg-client.jsm -> resource://gre/modules/devtools/transport/transport.js :: LocalDebuggerTransport.prototype.send/< :: line 545 JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js :: makeInfallible/< :: line 83 JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js :: makeInfallible/< :: line 83 native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
Reporter | ||
Comment 3•9 years ago
|
||
I still see this on OS X when not logged in to twitter.com at https://twitter.com/stshank for example.
Flags: needinfo?(jmuizelaar)
Assignee | ||
Comment 4•9 years ago
|
||
This was a really simple fix.
Attachment #8574654 -
Flags: review?(vporof)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → past
Status: NEW → ASSIGNED
Comment 5•9 years ago
|
||
Comment on attachment 8574654 [details] [diff] [review] Use the correct l10n keys for the event listeners pane Review of attachment 8574654 [details] [diff] [review]: ----------------------------------------------------------------- Oops
Attachment #8574654 -
Flags: review?(vporof) → review+
Assignee | ||
Comment 6•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/e814223f896b
https://hg.mozilla.org/mozilla-central/rev/e814223f896b
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
Assignee | ||
Updated•9 years ago
|
Assignee | ||
Comment 8•9 years ago
|
||
Comment on attachment 8574654 [details] [diff] [review] Use the correct l10n keys for the event listeners pane Approval Request Comment [Feature/regressing bug #]: bug 800857 [User impact if declined]: the events panel will be empty in the debugger for some sites [Describe test coverage new/current, TreeHerder]: feature is already tested and the fix is trivial [Risks and why]: insignificant risk, due to tiny change and devtools-only feature [String/UUID change made/needed]: none
Attachment #8574654 -
Flags: approval-mozilla-beta?
Attachment #8574654 -
Flags: approval-mozilla-aurora?
Comment 9•9 years ago
|
||
Comment on attachment 8574654 [details] [diff] [review] Use the correct l10n keys for the event listeners pane Although this looks to be a fairly longstanding bug, the fix is trivial and there is no need to ship this bug again in 37. Beta+ Aurora+
Attachment #8574654 -
Flags: approval-mozilla-beta?
Attachment #8574654 -
Flags: approval-mozilla-beta+
Attachment #8574654 -
Flags: approval-mozilla-aurora?
Attachment #8574654 -
Flags: approval-mozilla-aurora+
Updated•9 years ago
|
QA Whiteboard: [good first verify]
Comment 12•9 years ago
|
||
Reproduced with Firefox Nightly 36.0a1 on Windows 7 x64 Build ID: 20141118144012 User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:36.0) Gecko/20100101 Firefox/36.0 Verified as fixed with: Latest firefox beta 39.0b4 Build ID: 20150609130336 User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:39.0) Gecko/20100101 Firefox/39.0 Latest firefox release 38.0.5 Build ID: 20150525141253 User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Firefox/38.0 [bugday-20150610]
Comment 13•9 years ago
|
||
I have reproduced this bug with Nightly 36.0a1 (2014-11-18) with instruction from comment 0 and Linux x64. Verified as fixed with: latest Nightly 41.0a1 (2015-06-10) (Build ID: 20150610030209), Firefox Aurora 40.0a2 (2015-06-10) (Build ID: 20150610004004) and Firefox Beta 39.0b4 (Build ID: 20150609130336) Mozilla/5.0 (X11; Linux x86_64; rv:41.0) Gecko/20100101 Firefox/41.0 Mozilla/5.0 (X11; Linux x86_64; rv:40.0) Gecko/20100101 Firefox/40.0 Mozilla/5.0 (X11; Linux x86_64; rv:39.0) Gecko/20100101 Firefox/39.0 [bugday-20150610]
Comment 14•9 years ago
|
||
As per Comment 12 and Comment 13, Changing the status as verified!
Status: RESOLVED → VERIFIED
QA Whiteboard: [good first verify] → [good first verify][bugday-20150610]
Whiteboard: [bugday-20150610]
Comment 15•9 years ago
|
||
Same as in https://bugzilla.mozilla.org/show_bug.cgi?id=1138993#c25 - setting correct flags, and nice job verifying this!
status-firefox38.0.5:
--- → verified
status-firefox40:
--- → verified
status-firefox41:
--- → verified
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•