Closed Bug 1101217 (SQLite3.8.7.2) Opened 5 years ago Closed 5 years ago

Upgrade to SQLite 3.8.7.2

Categories

(Toolkit :: Storage, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla36

People

(Reporter: bent.mozilla, Assigned: bent.mozilla)

References

()

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
3.8.7.2 will be released tomorrow and includes a minimal fix needed for IndexedDB (see http://www.sqlite.org/src/info/d4b2d5d066891e06f2bf4337902b44b000fa9fd2).

A basic description of the bug is that any time a ROLLBACK happens when using a shared cache connection it invalidates any concurrent multi-row SELECT statements. This is now fixed.

Try: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=edb7220d8d9f

Marco, I'd really like to try to get this in before our next merge so that I can fix bug 1078438 also.
Attachment #8524910 - Flags: review?(mak77)
Depends on: SQLite3.8.7.1
Alias: SQLite3.8.7.2
Comment on attachment 8524910 [details] [diff] [review]
Patch

Review of attachment 8524910 [details] [diff] [review]:
-----------------------------------------------------------------

Sure, this is a minor release with bug fixes (I followed them through sqlite-users) so there shouldn't be any problem.

r=me with a green Try run.

::: db/sqlite3/README.MOZILLA
@@ +2,2 @@
>  
>  -- Ryan VanderMeulen <ryanvm@gmail.com>, 11/2014

Ideally you should fix this... but honestly, I don't think it's giving us any benefit that blame isn't already...

I'd vote to just remove this line to further simplify future upgrades.
Attachment #8524910 - Flags: review?(mak77) → review+
(In reply to Marco Bonardo [::mak] (needinfo? me) from comment #1)

Thanks!

> I'd vote to just remove this line to further simplify future upgrades.

Will do.
Target Milestone: --- → mozilla36
https://hg.mozilla.org/mozilla-central/rev/a930c7045988
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Depends on: 1101419
You need to log in before you can comment on or make changes to this bug.