1101223 - Assertion failure if child races

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1

There's a subtle race here when the child aborts a transaction but the parent has already sent a success event for another request. That causes some assertions to fire. This patch just moves the functions around and the adds an error path in DispatchSuccessEvent.

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8aad62212367

Comment 2

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8aad62212367

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 8524916 [details] [diff] [review]
Patch, v1

Approval Request Comment
[Feature/regressing bug #]: 994190
[User impact if declined]: Debug builds occasionally assert when using indexedDB, and release builds might see success events when they're supposed to receive error events, making 
[Describe test coverage new/current, TBPL]: There's no real test coverage for this because it's a race condition that is hard to make happen
[Risks and why]: Very low risk
[String/UUID change made/needed]: None

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/210f8669a990