Closed
Bug 1101225
Opened 10 years ago
Closed 10 years ago
Don't use ADTS in Android PDM
Categories
(Firefox for Android Graveyard :: Audio/Video, defect)
Firefox for Android Graveyard
Audio/Video
Tracking
(firefox34+ fixed, firefox35+ fixed, firefox36+ fixed, fennec34+)
VERIFIED
FIXED
Firefox 36
People
(Reporter: snorp, Assigned: snorp)
References
Details
Attachments
(2 files)
1021 bytes,
patch
|
rillian
:
review+
lmandel
:
approval-mozilla-aurora+
lmandel
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
3.06 KB,
patch
|
rillian
:
review+
rillian
:
checkin+
|
Details | Diff | Splinter Review |
The demuxer now sends raw AAC to the PDMs. We just need to tell that to MediaCodec.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8524919 -
Flags: review?(giles)
Comment 2•10 years ago
|
||
Comment on attachment 8524919 [details] [diff] [review] Don't set the is-adts flag for the Android PDM Review of attachment 8524919 [details] [diff] [review]: ----------------------------------------------------------------- r=me. sorry for messing that up.
Attachment #8524919 -
Flags: review?(giles) → review+
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8524919 [details] [diff] [review] Don't set the is-adts flag for the Android PDM Approval Request Comment [Feature/regressing bug #]: 1073805 [User impact if declined]: no AAC audio in mp4 files [Describe test coverage new/current, TBPL]: tested locally [Risks and why]: pretty low risk, tested locally [String/UUID change made/needed]: none Lawrence we'll need this on Aurora too because it's already busted there currently.
Attachment #8524919 -
Flags: approval-mozilla-beta?
Attachment #8524919 -
Flags: approval-mozilla-aurora?
Assignee | ||
Comment 4•10 years ago
|
||
Attachment #8524956 -
Flags: review?(giles)
Comment 5•10 years ago
|
||
Comment on attachment 8524956 [details] [diff] [review] Same patch for trunk Review of attachment 8524956 [details] [diff] [review]: ----------------------------------------------------------------- r=me. Thanks for the separate nightly patch.
Attachment #8524956 -
Flags: review?(giles) → review+
Updated•10 years ago
|
status-firefox34:
--- → affected
status-firefox35:
--- → affected
status-firefox36:
--- → affected
tracking-firefox34:
--- → +
tracking-firefox35:
--- → +
tracking-firefox36:
--- → +
Comment 6•10 years ago
|
||
Comment on attachment 8524919 [details] [diff] [review] Don't set the is-adts flag for the Android PDM OK. Let's get this on these branches. (snorp tells me that he's already tested the fix.) Beta+ Aurora+
Attachment #8524919 -
Flags: approval-mozilla-beta?
Attachment #8524919 -
Flags: approval-mozilla-beta+
Attachment #8524919 -
Flags: approval-mozilla-aurora?
Attachment #8524919 -
Flags: approval-mozilla-aurora+
Comment 7•10 years ago
|
||
Comment on attachment 8524956 [details] [diff] [review] Same patch for trunk https://hg.mozilla.org/integration/mozilla-inbound/rev/e30507b1a89f
Attachment #8524956 -
Flags: checkin+
Comment 8•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e30507b1a89f
Assignee: nobody → snorp
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 36
Assignee | ||
Comment 9•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/44cfd6a0019a
Assignee | ||
Updated•10 years ago
|
Assignee | ||
Updated•10 years ago
|
tracking-fennec: ? → 34+
Updated•10 years ago
|
Status: RESOLVED → VERIFIED
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•