1101228 - the argument passed to navigator.mozId.watch's onerror parameter callback is not an instanceof Event

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: FxA, defect)

Description

[(not reading bugmail) Nick Desaulniers [:\n]]

Most onXXXX event handlers are passed Event objects.  onerror is passed a string!!! that the user is expected to call JSON.parse on.  Not sure about the others (onlogout, onready, onlogin) but hopefully they're Event objects too and not strings.

Comment 1

[Sam Penrose]

(In reply to Nick Desaulniers [:\n] from comment #0)
> Most onXXXX event handlers are passed Event objects.  onerror is passed a
> string!!! that the user is expected to call JSON.parse on.  Not sure about
> the others (onlogout, onready, onlogin) but hopefully they're Event objects
> too and not strings.

The code is here:

  https://github.com/mozilla/gecko-dev/blob/master/dom/identity/nsDOMIdentity.js#L544

I know we have RPs relying on the current behavior, so we might need to patch it as part of the 2.2 cycle.

Comment 2

[(not reading bugmail) Nick Desaulniers [:\n]]

Maybe  `this._rpWatcher.onerror(JSON.stringify({name: msg.message.error}));` should be ` this._rpWatcher.onerror(new Event(msg.message.error));` though someone from the dom APIs team probably has a lot to say about this.

Comment 3

[BMO Automation]

Firefox OS is not being worked on