There are requirements for snippet code documented at https://abouthome-snippets-service.readthedocs.org/en/latest/developing.html#snippet-requirements. There's also some style guides used across webdev that we like to subscribe to, documented at http://mozweb.readthedocs.org/en/latest/. It's a PITA to spend time during code reviews bothering with these nits. gvn posted an interesting blog post (https://gist.github.com/gvn/7536832) essentially recommending that you automate these rules rather than making humans check them. I think this is a grand idea, and one that should be investigated! One possible piece of this could be stylecop, potch's project to easily enforce odd rules against a CSS codebase: https://github.com/potch/stylecop
Since you linked mozweb read the docs does this mean that we are following PEP8 in snippets?
Commit pushed to master at https://github.com/mozilla/snippets-service https://github.com/mozilla/snippets-service/commit/8ac8ae045a39c54687243ae6d489f3ba0cf3be23 [bug 1101253] Add flake8 check to travis.
Fixed and merged in https://github.com/mozilla/snippets-service/compare/c707e13d6c15...8b4bcb04ad73. Travis should now comment on PRs with linting status. Nice work!
Assignee: nobody → koddsson
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.