1101259 - Configuration of preferred codec should be based on codec name, not payload type

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect, P4)

Description

[Byron Campen [:bwc]]

Right now, media.navigator.video.preferred_codec takes a payload type number, like "126", but should really be taking something more like "H264"

Comment 1

[Bulk Bug Changes for mreavy's org]

Mass change P3->P4 to align with new Mozilla triage process.

Comment 2

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1101259 - preferred webrtc codec pref should accept codec name;r?bwc

Comment 3

[Nico Grunbaum [:ng, @chew:mozilla.org]]

This pref is currently broken, and unused. I am going to remove the pref but keep the functionality.

[50026] Hit MOZ_CRASH(Should not access the preference 'media.navigator.video.preferred_codec' in the Content Processes) at /Users/ng/dev/mozilla-unified/modules/libpref/Preferences.cpp:1217
#01: PrefWrapper::WantValueKind(mozilla::PrefType, mozilla::PrefValueKind) const[/Users/ng/dev/build/opt-obj-aarch64-apple-darwin23.5.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x6911d8]
#02: nsresult mozilla::Internals::GetPrefValue<int*&>(char const*, int*&, mozilla::PrefValueKind)[/Users/ng/dev/build/opt-obj-aarch64-apple-darwin23.5.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x67381c]
#03: nsPrefBranch::GetIntPref(char const*, int*)[/Users/ng/dev/build/opt-obj-aarch64-apple-darwin23.5.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x5cf4cc]
#04: mozilla::PeerConnectionImpl::ConfigureJsepSessionCodecs()[/Users/ng/dev/build/opt-obj-aarch64-apple-darwin23.5.0/dist/NightlyDebug.app/Contents/MacOS/XUL +0x459c938]

Comment 4

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Attachment: Bug 1101259 - remove references to media.navigator.video.preferred_codec;r?bwc

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98de71768403
preferred webrtc codec pref should accept codec name;r=bwc
https://hg.mozilla.org/integration/autoland/rev/1df9ac8602b2
remove references to media.navigator.video.preferred_codec;r=bwc

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/98de71768403
https://hg.mozilla.org/mozilla-central/rev/1df9ac8602b2